Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: "Jonathan Riches" <jon.riches@westbridge-design.co.uk>
To: <gdb@sourceware.cygnus.com>, <bystricky.juro@erd.epson.com>
Subject: OCD - wiggler baud rate problem
Date: Wed, 29 Aug 2001 09:20:00 -0000	[thread overview]
Message-ID: <005901c130a3$799dc5f0$ea0018ac@proteus> (raw)

Thanks Juro for the info.  It appears that in GDB 5.0 (ocd.c) that all ocd
writes / reads are as bytes, this would account for the problem I also had
in writing an init file, where the SYPCR was only getting 1 byte written,
then it was set for good.

I have found the download speed using wiggler has risen from 10,000 bits/sec
to 25,000,
Regards
Jonathan Riches

Juro wrote >
#######################################################################
Hi Jonathan

There's a bug in OCD.C, I reported it to macraigor:

the file load was SIGNIFICANTLY
slower. Using Raven I achieved the equivalent of about 9600 baud rate.
So I started comparing the old code with the new one and found a serious
bug:

in the file OCD.C you try to determine if to read/write words, halfwords or
bytes.

Your code:
=======================================================
if      ( ((memaddr & 4) == 4) || ((len & 4) == 4) )
   buf[5] = 4;  /* Word align and word length */
else if ( ((memaddr & 2) == 2) || ((len & 2) == 2) )
   buf[5] = 2; /* TWO BYTE WRITE */
else
   buf[5] = 1;  /* default to byte write */
=====================================================

is clearly wrong. You probably meant something like:

=====================================================
  if ( ((memaddr & 3) == 0) && ((len & 3) == 0) )
    buf[5] = 4;  /* Word align and word length */
  else if ( ((memaddr & 1) == 0) && ((len & 1) == 0) )
    buf[5] = 2; /* TWO BYTE WRITE */
  else
    buf[5] = 1;  /* default to byte write */

=====================================================

The same code occurs in two different places.
Indeed, after replacing the code we were back up to the speed
#####################################################################



             reply	other threads:[~2001-08-29  9:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-29  9:20 Jonathan Riches [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-08-28  9:16 Jonathan Riches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='005901c130a3$799dc5f0$ea0018ac@proteus' \
    --to=jon.riches@westbridge-design.co.uk \
    --cc=bystricky.juro@erd.epson.com \
    --cc=gdb@sourceware.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox