From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72215-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26562 invoked by alias); 17 Apr 2010 18:50:20 -0000
Received: (qmail 26508 invoked by uid 22791); 17 Apr 2010 18:50:18 -0000
X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 	tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45
X-Spam-Check-By: sourceware.org
Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Apr 2010 18:50:13 +0000
Received: by vws8 with SMTP id 8so1961781vws.0         for <gdb-patches@sourceware.org>; Sat, 17 Apr 2010 11:50:11 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.44.198 with HTTP; Sat, 17 Apr 2010 11:50:11 -0700 (PDT)
In-Reply-To: <201004171625.o3HGPc93029549@glazunov.sibelius.xs4all.nl>
References: <20100417161115.GA25919@intel.com> 	 <201004171625.o3HGPc93029549@glazunov.sibelius.xs4all.nl>
Date: Sat, 17 Apr 2010 18:50:00 -0000
Received: by 10.220.123.104 with SMTP id o40mr2113481vcr.208.1271530211182;  	Sat, 17 Apr 2010 11:50:11 -0700 (PDT)
Message-ID: <z2q6dc9ffc81004171150z164a5fb2y727e835914421f6b@mail.gmail.com>
Subject: Re: PATCH: PR corefiles/11511: gcore doesn't work with orig_rax on  	Linux/amd64
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00534.txt.bz2

On Sat, Apr 17, 2010 at 9:25 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wr=
ote:
>> Date: Sat, 17 Apr 2010 09:11:15 -0700
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>
>> This patch adds orig_rax support to amd64_linux_gregset_reg_offset.
>> amd64 has both tdep->gregset_reg_offset/tdep->gregset_num_regs and
>> amd64_native_gregset64_reg_offset/amd64_native_gregset64_num_regs. =A0Th=
ey
>> are identical. There is no need to keep both. =A0This patch also removes
>> amd64_native_gregset64_reg_offset/amd64_native_gregset64_num_regs. OK
>> to install?
>
> No. =A0I want to keep the -nat.c and -tdep.c code separate.

Can I replace amd64_linux_gregset64_reg_offset with
amd64_linux_gregset_reg_offset, like amd64nbsd-nat.c
and amd64obsd-nat.c?

Thanks.

H.J.
--
> The bit below is ok, but please drop the other bits.
>
>> =A0 =A0 =A0 * amd64-linux-tdep.c (amd64_linux_gregset_reg_offset): Suppo=
rt
>> =A0 =A0 =A0 orig_rax.
>
>> diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c
>> index 1205e31..f249d5d 100644
>> --- a/gdb/amd64-linux-tdep.c
>> +++ b/gdb/amd64-linux-tdep.c
>> @@ -87,7 +87,14 @@ static int amd64_linux_gregset_reg_offset[] =3D
>> =A0 =A023 * 8, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/* %ds */
>> =A0 =A024 * 8, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/* %es */
>> =A0 =A025 * 8, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/* %fs */
>> - =A026 * 8 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* %gs */
>> + =A026 * 8, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/* %gs */
>> + =A0-1, -1, -1, -1, -1, -1, -1, -1,
>> + =A0-1, -1, -1, -1, -1, -1, -1, -1,
>> + =A0-1, -1, -1, -1, -1, -1, -1, -1,
>> + =A0-1, -1, -1, -1, -1, -1, -1, -1, -1,
>> + =A0-1, -1, -1, -1, -1, -1, -1, -1,
>> + =A0-1, -1, -1, -1, -1, -1, -1, -1,
>> + =A015 * 8 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* "orig_rax" */
>> =A0};
>>
>>
>



--=20
H.J.