From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12567 invoked by alias); 7 Nov 2002 01:28:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12559 invoked from network); 7 Nov 2002 01:28:11 -0000 Received: from unknown (HELO mms2.broadcom.com) (63.70.210.59) by sources.redhat.com with SMTP; 7 Nov 2002 01:28:11 -0000 Received: from 63.70.210.1mms2.broadcom.com with ESMTP (Broadcom MMS2 SMTP Relay (MMS v5.0)); Wed, 06 Nov 2002 17:25:43 -0800 X-Server-Uuid: 59F48136-7074-4F4B-B709-D7F3B6466DB0 Received: from mail-sj1-5.sj.broadcom.com (mail-sj1-5.sj.broadcom.com [10.16.128.236]) by mon-irva-11.broadcom.com (8.9.1/8.9.1) with ESMTP id RAA10664; Wed, 6 Nov 2002 17:28:07 -0800 (PST) Received: from dt-sj3-118.sj.broadcom.com (dt-sj3-118 [10.21.64.118]) by mail-sj1-5.sj.broadcom.com (8.12.4/8.12.4/SSF) with ESMTP id gA71S7ER006072; Wed, 6 Nov 2002 17:28:07 -0800 (PST) Received: (from cgd@localhost) by dt-sj3-118.sj.broadcom.com ( 8.9.1/SJ8.9.1) id RAA25602; Wed, 6 Nov 2002 17:28:03 -0800 (PST) To: "Andrew Cagney" cc: rsandifo@redhat.com, gdb-patches@sources.redhat.com Subject: Re: sim/mips patch: add support for more NEC VR targets References: <3DC9B7CF.8050401@redhat.com> From: cgd@broadcom.com Date: Wed, 06 Nov 2002 17:28:00 -0000 In-Reply-To: "Andrew Cagney"'s message of "Wed, 06 Nov 2002 19:46:07 -0500" Message-ID: MIME-Version: 1.0 X-WSS-ID: 11D71E9D66862-01-01 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-SW-Source: 2002-11/txt/msg00159.txt.bz2 At Wed, 06 Nov 2002 19:46:07 -0500, Andrew Cagney wrote: > >> - gen-engine.c adds the global prefix to the beginning of > >> ENGINE_ISSUE_(PREFIX|POSTFIX)_HOOK. It seems MIPS is the > >> only back-end to define these macros, and it never adds a > >> prefix. The patch adjusts igen accordingly. > > > > > > Hmm. I don't know igen so well. Andrew? What are your thoughts > > here? > > [I suspect its already been committed] > So, how did it ever build? Err, well, build is no problem: the code in question did #if defined(%sENGINE_ISSUE_PREFIX_HOOK)... so it won't get in there. > Specify two functions. One for the mips5500 and one for the rest. That > way, there isn't any reason for adding TATE_ARCHITECTURE (SD)->mach == > bfd_mach_mips5500. > > It will also solve the default machine problem. well: (1) w/ separate fn, you'd need to tag _all_ of the 5500 machine insns w/ mips5500. (as opposed to ISA + a few mips5500 extensions.) (2) it doesn't actually solve the default machine problem, since you need to e.g. pick the right machine (possibly picking default) in sim_engine_run, and you need to pick the right machine (again possibly picking default) if doing e.g. MD cp0 register handling. (I've got a lot of code yet to be submitted that does the latter.) chris