From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5311 invoked by alias); 11 Apr 2003 06:03:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5296 invoked from network); 11 Apr 2003 06:03:25 -0000 Received: from unknown (HELO mms1.broadcom.com) (63.70.210.58) by sources.redhat.com with SMTP; 11 Apr 2003 06:03:25 -0000 Received: from 63.70.210.1 by mms1.broadcom.com with ESMTP (Broadcom MMS3 SMTP Relay (MMS v5.5.2)); Thu, 10 Apr 2003 23:03:07 -0700 Received: from mail-sj1-5.sj.broadcom.com (mail-sj1-5.sj.broadcom.com [10.16.128.236]) by mon-irva-11.broadcom.com (8.9.1/8.9.1) with ESMTP id XAA21889; Thu, 10 Apr 2003 23:03:00 -0700 (PDT) Received: from dt-sj3-118.sj.broadcom.com (dt-sj3-118 [10.21.64.118]) by mail-sj1-5.sj.broadcom.com (8.12.4/8.12.4/SSF) with ESMTP id h3B63GER016173; Thu, 10 Apr 2003 23:03:17 -0700 (PDT) Received: (from cgd@localhost) by dt-sj3-118.sj.broadcom.com ( 8.9.1/SJ8.9.1) id XAA18710; Thu, 10 Apr 2003 23:03:09 -0700 (PDT) To: aoliva@redhat.com cc: "Andrew Cagney" , gdb-patches@sources.redhat.com, binutils@sources.redhat.com Subject: Re: use MIPS NewABI register names when disassembling NewABI code References: <3E927BCA.1080702@redhat.com> <3E93391F.2050005@redhat.com> <3E94339A.8030405@redhat.com> From: cgd@broadcom.com Date: Fri, 11 Apr 2003 06:03:00 -0000 In-Reply-To: aoliva@redhat.com's message of "Fri, 11 Apr 2003 05:43:18 +0000 (UTC)" Message-ID: MIME-Version: 1.0 X-WSS-ID: 12888511495178-01-01 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-SW-Source: 2003-04/txt/msg00228.txt.bz2 At Fri, 11 Apr 2003 05:43:18 +0000 (UTC), "Alexandre Oliva" wrote: > * mips-dis.c (_print_insn_mips): Override reg_names from > disassembler_options. Uh... Well... "I'm not the maintainer, but i'd say no." 8-) Note the line: parse_mips_dis_options (info->disassembler_options); about 18 lines above your new lines. It already supports what you want, but with a different syntax. > + tm_print_insn_info.disassembler_options = "NewABI"; "gpr_names=ABI" instead, for values of ABI: 32, n32, 64. note that, as you probably expect 32 -> oldabi and n32,64 -> newabi. (default -> oldabi) IMO it's best to use the correct names for ABIs (i.e., for the above-named ones or others) so that somebody can add a new ABI easily to "the obvious place" in GDB, and to the obvious place in the disassembler, and the right thing should happen automatically. (It's a real bummer that there's no existing way to return an error for invalid disassembler options, or i would have coded in some error reporting. 8-) (Also note that there's also support for doing the ABI-specific FP register names, but that's a different option because everybody refers to them numerically anyway.) The rest of the gdb disassembler_options setup looks compatible with the code in the disassembler, but it was a very quick look. 8-) chris