From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28312 invoked by alias); 18 Jun 2003 01:18:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20056 invoked from network); 18 Jun 2003 01:14:16 -0000 Received: from unknown (HELO mms3.broadcom.com) (63.70.210.38) by sources.redhat.com with SMTP; 18 Jun 2003 01:14:16 -0000 Received: from 63.70.210.1 by mms3.broadcom.com with ESMTP (Broadcom SMTP Relay (MMS v5.5.2)); Tue, 17 Jun 2003 18:14:07 -0700 Received: from mail-sj1-5.sj.broadcom.com (mail-sj1-5.sj.broadcom.com [10.16.128.236]) by mon-irva-11.broadcom.com (8.9.1/8.9.1) with ESMTP id SAA05937; Tue, 17 Jun 2003 18:13:33 -0700 (PDT) Received: from ldt-sj3-010.sj.broadcom.com (ldt-sj3-010 [10.21.64.10]) by mail-sj1-5.sj.broadcom.com (8.12.9/8.12.9/SSF) with ESMTP id h5I1Dsov014999; Tue, 17 Jun 2003 18:13:54 -0700 (PDT) Received: (from cgd@localhost) by ldt-sj3-010.sj.broadcom.com ( 8.11.6/8.9.3) id h5I1DrG22633; Tue, 17 Jun 2003 18:13:53 -0700 X-Authentication-Warning: ldt-sj3-010.sj.broadcom.com: cgd set sender to cgd@broadcom.com using -f To: ac131313@redhat.com cc: "Richard Sandiford" , gdb-patches@sources.redhat.com Subject: Re: [mips sim]: Fix check for negative dmult operands References: <3EECA6FE.4010407@redhat.com> From: cgd@broadcom.com Date: Wed, 18 Jun 2003 01:18:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 MIME-Version: 1.0 X-WSS-ID: 12F163551348076-01-01 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00589.txt.bz2 At Sun, 15 Jun 2003 17:04:28 +0000 (UTC), "Andrew Cagney" wrote: > Yes, just add a comment reminding the reader that op1 is already 64 bits. op1 and op2 and defined approximately 10 lines above as: unsigned64 op1 = GPR[rs]; unsigned64 op2 = GPR[rt]; so IMO their 64-bitness is fairly clear already. cgd