From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2748 invoked by alias); 3 Nov 2004 16:54:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2729 invoked from network); 3 Nov 2004 16:54:49 -0000 Received: from unknown (HELO mms2.broadcom.com) (63.70.210.59) by sourceware.org with SMTP; 3 Nov 2004 16:54:49 -0000 Received: from 63.70.210.1 by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (MMS v5.6.0)); Wed, 03 Nov 2004 08:54:39 -0800 X-Server-Uuid: 011F2A72-58F1-4BCE-832F-B0D661E896E8 Received: from mail-sj1-5.sj.broadcom.com (mail-sj1-5.sj.broadcom.com [10.16.128.236]) by mon-irva-10.broadcom.com (8.9.1/8.9.1) with ESMTP id IAA06379; Wed, 3 Nov 2004 08:54:45 -0800 (PST) Received: from ldt-sj3-010.sj.broadcom.com (ldt-sj3-010 [10.21.64.10]) by mail-sj1-5.sj.broadcom.com (8.12.9/8.12.9/SSF) with ESMTP id iA3Gscov018321; Wed, 3 Nov 2004 08:54:39 -0800 (PST) Received: (from cgd@localhost) by ldt-sj3-010.sj.broadcom.com ( 8.11.6/8.9.3) id iA3Gscl06599; Wed, 3 Nov 2004 08:54:38 -0800 X-Authentication-Warning: ldt-sj3-010.sj.broadcom.com: cgd set sender to cgd@broadcom.com using -f To: davidu@mips.com cc: gdb-patches@sources.redhat.com, cagney@redhat.com Subject: Re: MIPS32 / MIPS64 release 2 support in simulator References: <1099495559.2778.53.camel@stockwell.mips.com> From: cgd@broadcom.com Date: Wed, 03 Nov 2004 16:54:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 MIME-Version: 1.0 X-WSS-ID: 6D97D2C51PO4416254-01-01 Content-Type: multipart/mixed; boundary="=-=-=" X-SW-Source: 2004-11/txt/msg00043.txt.bz2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 2748 Andrew (or somebody), could you please confirm that their assignment is in place? (I don't have access to anything that would let me check easily, as far as I know.) At Wed, 3 Nov 2004 15:26:27 +0000 (UTC), "David Ung" wrote: > The following file is for MIPS32 / MIPS64 release 2 extensions to the > simulator. Based on the way other bits are done: * these should be placed in mips.igen proper (since they're part of a standard MIPS ISA level). If you'd like to try dissuade me from this position, I'm willing to discuss it. But right now, all *other* standard MIPS ISA bits are in mips.igen itself. * the lines like: *mips32,mips64: should be two separate lines. Also: * If you can't provide diffs for new files, at least provide them as an attachment. (If you're interested in faking out CVS so you can provide the diffs easily, see the attached script.) Otherwise, I have fears about whitespace and/or line wrapping. * If you do convince me that a new .igen file is appropriate, you'll need to put an appropriate copyright notice and license on it. I'd suggest starting with the one on, say, mips3d.igen. * You need testsuite coverage for all of the new instructions, please. * Please carefully review the instruction implementations against the manuals, and against the defines and functions already provided by the simulator. Right now, there are some issues. For instance: * DI, EI should sign extend the result, and should use status_IE rather than '1'. * I believe you should be using TRACE_ALU_INPUT0 in DI, EI and in possibly similar places. * you are missing letters in wrpgpr and rdpgpr in comment. * in dshd, I get what you're trying to do, but the code should be less complex to do it. (in particular, the use of the 0xffff0000 masks is confusing). Just write the code the obvious way. 8-) * should use check_fpu in FPU ops, and I believe you should be using check_u64 in the 64-bit ops. Also, appropriate use of NotWordValue would be good. * should probably just move the ror/rorv instructions from vr.igen into mips.igen, and use them since they are as far as I know otherwise the same. Yes, I know they don't print out w/ the official MIPS mnemonics, but the assembler recognizes both and, well, uh, MIPS named them last. 8-) There may be more, those are just the things I noticed on a quick read-through. (Obviously, I'll have to review any updated patch.) (We did an implementation of r2, too, but I've never had time to submit it back. *sigh* Now *I* get to lose on the merge. 8-) chris --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=fakeadd Content-Transfer-Encoding: 7bit Content-length: 666 #!/bin/sh if [ $# -eq 0 ]; then echo "usage: $0 file ..." 1>&2 exit 1 fi if [ -d CVS ]; then :; else echo "$0: fatal error: no CVS directory! exit 1 fi if [ -f CVS/Entries ] && [ -w CVS/Entries ]; then :; else echo "$0: fatal error: CVS/Entries file not writable! exit 1 fi rv=0 for file in "$@"; do if [ -f "$file" ]; then :; else echo "$0: error: \"$file\" does not exist or is not a plain file" rv=1 continue fi if grep "^/$file/" CVS/Entries > /dev/null 2>&1; then echo "$0: error: \"$file\" is already listed in CVS/Entries" rv=1 continue fi echo "/$file/0/dummy timestamp//" >> CVS/Entries echo "$0: added \"$file\"" done exit $rv --=-=-=--