From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21202 invoked by alias); 25 Aug 2003 22:59:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21168 invoked from network); 25 Aug 2003 22:58:52 -0000 Received: from unknown (HELO mms2.broadcom.com) (63.70.210.59) by sources.redhat.com with SMTP; 25 Aug 2003 22:58:52 -0000 Received: from 63.70.210.1 by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (MMS v5.5.3)); Mon, 25 Aug 2003 15:55:10 -0700 Received: from mail-sj1-5.sj.broadcom.com (mail-sj1-5.sj.broadcom.com [10.16.128.236]) by mon-irva-11.broadcom.com (8.9.1/8.9.1) with ESMTP id PAA22231; Mon, 25 Aug 2003 15:58:16 -0700 (PDT) Received: from ldt-sj3-010.sj.broadcom.com (ldt-sj3-010 [10.21.64.10]) by mail-sj1-5.sj.broadcom.com (8.12.9/8.12.9/SSF) with ESMTP id h7PMwfov002699; Mon, 25 Aug 2003 15:58:41 -0700 (PDT) Received: (from cgd@localhost) by ldt-sj3-010.sj.broadcom.com ( 8.11.6/8.9.3) id h7PMwfk17358; Mon, 25 Aug 2003 15:58:41 -0700 X-Authentication-Warning: ldt-sj3-010.sj.broadcom.com: cgd set sender to cgd@broadcom.com using -f To: ac131313@redhat.com cc: gdb-patches@sources.redhat.com Subject: Re: Re-RFA re: [almost-obvious patch, and 6.0 RFA] treat mipsisa64 as 64-bit MIPS. References: <3F4A2B9B.90409@redhat.com> From: cgd@broadcom.com Date: Mon, 25 Aug 2003 22:59:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 MIME-Version: 1.0 X-WSS-ID: 13544C44620668-01-01 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2003-08/txt/msg00441.txt.bz2 At Mon, 25 Aug 2003 15:30:47 +0000 (UTC), "Andrew Cagney" wrote: > - put the patterns at the start, vis: > mipsisa64*-*-linux* ) gdb_target=linux64 ;; > mipsisa64*-*-* ) gdb_target=embed64 ;; > I think this is all that is needed. It seems that my recent MIPS > target purge missed a few cases. ahh, yes. Looks like: tx39.mt == tx39l.mt embed64.mt == embedl64.mt mips.mt == embedl.mt (!!! except for comments; this one is puzzling!) so probably more could be collapsed later. > It can probably be simplified further (mips*64*-*-*?) but, as you > note, harm minimization is in order. Yeah, for some reason i don't like using "mips*64". dunno why it bugs me, though. Patch as re-tested with mipsisa64-elf gdb and checked in (trunk & branch) is below. thanks, chris -- 2003-08-25 Chris Demetriou * configure.tgt: Document need for special "mipsisa64" handling. (mipsisa64*-*-linux64): Handle as target linux64. (mipsisa64*-*-*): Handle as target embed64. Index: configure.tgt =================================================================== RCS file: /cvs/src/src/gdb/configure.tgt,v retrieving revision 1.111 diff -u -p -r1.111 configure.tgt --- configure.tgt 1 Aug 2003 21:14:33 -0000 1.111 +++ configure.tgt 25 Aug 2003 22:55:39 -0000 @@ -143,6 +143,12 @@ m68*-*-sysv4*) gdb_target=m68kv4 ;; m68*-*-vxworks*) gdb_target=vxworks68 ;; mcore*-*-*) gdb_target=mcore ;; + +# "mipsisa64" targets are 64-bit MIPS, MIPS64 ISA. They need these +# special cases because otherwise they (obviously) are not matched by +# the "mips64" target cases, and would therefore be treated as 32-bit. +mipsisa64*-*-linux*) gdb_target=linux64 ;; +mipsisa64*-*-*) gdb_target=embed64 ;; mips64*-big-*) gdb_target=mips64 ;; mips*-big-*) gdb_target=mips ;; mips*-dec-*) gdb_target=mips ;;