Re: [RFA, doc RFA] Fix symtab/15885

Tom Tromey
2013-08-26T15:49:47Z

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> I think there is more cleanup to be had beyond reread_symbols,
Doug> but again I don't want this patch bogged down in that.

More evidence that reread_symbols should go the free_objfile route. I
agree it isn't needed for this fix though.

Doug> + if {[run_on_host "objcopy" [transform objcopy] "--remove-section .gdb_index --add-section .gdb_index=$index_file --set-section-flags .gdb_index=readonly ${program} ${program_with_index}"]} {

This line looks over-long.

Otherwise the patch looks fine to me.

Tom