From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28940 invoked by alias); 29 Aug 2013 18:12:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28929 invoked by uid 89); 29 Aug 2013 18:12:02 -0000 Received: from mail-qc0-f202.google.com (HELO mail-qc0-f202.google.com) (209.85.216.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 29 Aug 2013 18:12:02 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_SOFTFAIL autolearn=ham version=3.3.2 X-HELO: mail-qc0-f202.google.com Received: by mail-qc0-f202.google.com with SMTP id l13so67855qcy.3 for ; Thu, 29 Aug 2013 11:11:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-type; bh=UeG5VNijKeU8IPXP37JpcTnW6x50UV0STLFybXSFW5M=; b=KJquhRC2B0qxKUnPwNiTPwU8vt4m52AvnluSIlRTjXfX3fL9RBM1Ge95Xqy+rySnTv JMtDRwYxvtN+OIU4m0AgsbgeH3s1hu/cuXLm7Mqst+T1QDftjdPsFqWLPcZKC8Z9g0+Y n4DXEcjaKnQf9gzgzM5TekFX9OmzDGqTrzb7zks9PUYcvE9WtPXKKvwy8d5LyBBHSk1e PhTKJXRmNXCJS99RfZXLAyzMbkpXkDuvaHj1ynt3XK2tHk04IRbZdOnR3Iokr4BlAl9a BWc+8IbiExAUc06emKrKFBSnaB3PrlbyhyMMZsQHVzunr5fyARVJw6Y7a8u5cMMJYJSq kgqQ== X-Gm-Message-State: ALoCoQkzQuNKGl1vluOgIRpYl/s98l6g/IWLHQTWBHE35g5R5DBMkCbVUszoR+V8obJztBXht6OiNvx3K2U6ZM7ToZOs7HD/P7hJOAH4m+hnjmOT8fTE3wWrnejeDjm4dcv1bC7kvs3ZXh3OgzwqJxLYdyDF/BQal0hh57VPXQsDjNVWMSTXEN5PlcwLD5h7IjNZ/PB2y7RrUxsp2JizV9fz5mhEtTLU0S1AyTfJ61xNNgelydlUd8E= X-Received: by 10.236.209.103 with SMTP id r67mr1772706yho.35.1377799919408; Thu, 29 Aug 2013 11:11:59 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id z29si1993589yhd.3.1969.12.31.16.00.00 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Thu, 29 Aug 2013 11:11:59 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 04F9331C111 for ; Thu, 29 Aug 2013 11:11:58 -0700 (PDT) From: Doug Evans To: gdb-patches@sourceware.org Subject: [RFA] Remove unnecessary call to save_current_inferior Date: Thu, 29 Aug 2013 18:12:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2013-08/txt/msg00884.txt.bz2 Hi. AFAICT the call to save_current_inferior here is unnecessary. Regression tested on amd64-linux. Ok to check in? 2013-08-29 Doug Evans * progspace.c (save_current_space_and_thread): Remove unnecessary call to save_current_inferior. Index: progspace.c =================================================================== RCS file: /cvs/src/src/gdb/progspace.c,v retrieving revision 1.18 diff -u -p -r1.18 progspace.c --- progspace.c 28 Aug 2013 17:52:03 -0000 1.18 +++ progspace.c 29 Aug 2013 17:58:15 -0000 @@ -471,7 +471,8 @@ save_current_space_and_thread (void) /* If restoring to null thread, we need to restore the pspace as well, hence, we need to save the current program space first. */ old_chain = save_current_program_space (); - save_current_inferior (); + /* There's no need to save the current inferior here. + That is handled by make_cleanup_restore_current_thread. */ make_cleanup_restore_current_thread (); return old_chain;