From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24292 invoked by alias); 17 Dec 2013 21:43:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24280 invoked by uid 89); 17 Dec 2013 21:43:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f201.google.com Received: from mail-ie0-f201.google.com (HELO mail-ie0-f201.google.com) (209.85.223.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 17 Dec 2013 21:43:31 +0000 Received: by mail-ie0-f201.google.com with SMTP id at1so1362077iec.2 for ; Tue, 17 Dec 2013 13:43:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-type; bh=uTKMdRm4k1rO6YVRGS9jynTIR86u/9dyGPmeRT/gQY4=; b=dSJR5ufLZ7tC3cB3hXZL+HzUB0UPdBNqxbx0gWUbNYMrOfxTNk5hO+h9+uINCWCsmK JS4dXt2VZn8zrMgB+EVVogcRR31Akkd3uj+UQGKg4dyZpv3SKSG+RU3/pih36PyTaNm7 duvyI4nSuTxUdVyQ98Pg8BGoWQ0vFton/sQZtwsyg3nveU10rFlr20Mptbb+ILeDqdtU sQmdW02n5extTcnRilUFLizTqHgnxgjxHIUsCwwWTQ+zEPVmI8P63Q7NnCUDjVoffwkG O5Br4ZPwciE0IEfkQqsHSYi+/QZRU7nsRfo+sda+yN6LMDkkCkUsQzEu4pA81uZ0gmMv Up7A== X-Gm-Message-State: ALoCoQlUo8jmCARKl/TOfYLAxeL5sIgPkskTL3k0LzMp/8XroQW1t0vfBGkyqshbJuADymtTRUYCv9dvaI8lEsIgPCDEmbaApCX2WU4py5DtINSheIgKPpu7qhYrr/elrsfHlJ+BynrstV5qmXuEZVRZztilOcUuXURJNs61dFX/Va7LXrRsgBaLz2llEAGzSZdrplh0cDvVa5v66rE6aCmkfV1yRoMmleWDIKyjuIPzGjGHIND1tjc= X-Received: by 10.42.51.141 with SMTP id e13mr3223408icg.28.1387316610190; Tue, 17 Dec 2013 13:43:30 -0800 (PST) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id o30si4834252yhn.1.2013.12.17.13.43.30 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Dec 2013 13:43:30 -0800 (PST) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id B93C35A420E for ; Tue, 17 Dec 2013 13:43:29 -0800 (PST) From: Doug Evans To: gdb-patches@sourceware.org Subject: [PATCH 2/6] gdbserver: remove function abbrevs from debugging text Date: Tue, 17 Dec 2013 21:43:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00669.txt.bz2 Hi. This patch removes the function abbreviations from the debugging output. In one example it's wrong (GPS vs get_detach_signal), and I rarely keep in cache the translation to function name. 2013-12-17 Doug Evans * linux-low.c (linux_kill_one_lwp): Replace LKL with linux_kill_one_lwp in debugging printf. (get_detach_signal): Replace GPS with get_detach_signal in debugging printf. Remove extraneous "lwp" in output. (cancel_breakpoint): Replace CB with get_detach_signal in debugging printf. (select_event_lwp): Replace SEL with select_event_lwp in debugging printf. --- gdb/gdbserver/linux-low.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index 770ee16..464aaf0 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -899,7 +899,7 @@ linux_kill_one_lwp (struct lwp_info *lwp) kill (pid, SIGKILL); if (debug_threads) fprintf (stderr, - "LKL: kill (SIGKILL) %s, 0, 0 (%s)\n", + "linux_kill_one_lwp: kill (SIGKILL) %s, 0, 0 (%s)\n", target_pid_to_str (ptid_of (lwp)), errno ? strerror (errno) : "OK"); @@ -907,7 +907,7 @@ linux_kill_one_lwp (struct lwp_info *lwp) ptrace (PTRACE_KILL, pid, (PTRACE_TYPE_ARG3) 0, (PTRACE_TYPE_ARG4) 0); if (debug_threads) fprintf (stderr, - "LKL: PTRACE_KILL %s, 0, 0 (%s)\n", + "linux_kill_one_lwp: PTRACE_KILL %s, 0, 0 (%s)\n", target_pid_to_str (ptid_of (lwp)), errno ? strerror (errno) : "OK"); } @@ -1032,7 +1032,8 @@ get_detach_signal (struct thread_info *thread) { if (debug_threads) fprintf (stderr, - "GPS: lwp %s hasn't stopped: no pending signal\n", + "get_detach_signal: %s hasn't stopped: " + "no pending signal\n", target_pid_to_str (ptid_of (lp))); return 0; } @@ -1042,7 +1043,7 @@ get_detach_signal (struct thread_info *thread) { if (debug_threads) fprintf (stderr, - "GPS: lwp %s had stopped with extended " + "get_detach_signal: %s had stopped with extended " "status: no pending signal\n", target_pid_to_str (ptid_of (lp))); return 0; @@ -1054,7 +1055,8 @@ get_detach_signal (struct thread_info *thread) { if (debug_threads) fprintf (stderr, - "GPS: lwp %s had signal %s, but it is in nopass state\n", + "get_detach_signal: %s had signal %s, but it is " + "in nopass state\n", target_pid_to_str (ptid_of (lp)), gdb_signal_to_string (signo)); return 0; @@ -1067,7 +1069,7 @@ get_detach_signal (struct thread_info *thread) { if (debug_threads) fprintf (stderr, - "GPS: lwp %s had signal %s, " + "get_detach_signal: %s had signal %s, " "but we don't know if we should pass it. Default to not.\n", target_pid_to_str (ptid_of (lp)), gdb_signal_to_string (signo)); @@ -1077,7 +1079,8 @@ get_detach_signal (struct thread_info *thread) { if (debug_threads) fprintf (stderr, - "GPS: lwp %s has pending signal %s: delivering it.\n", + "get_detach_signal: %s has pending signal %s: " + "delivering it.\n", target_pid_to_str (ptid_of (lp)), gdb_signal_to_string (signo)); @@ -1735,7 +1738,7 @@ cancel_breakpoint (struct lwp_info *lwp) { if (debug_threads) fprintf (stderr, - "CB: Push back breakpoint for %s\n", + "cancel_breakpoint: Push back breakpoint for %s\n", target_pid_to_str (ptid_of (lwp))); /* Back up the PC if necessary. */ @@ -1753,7 +1756,7 @@ cancel_breakpoint (struct lwp_info *lwp) { if (debug_threads) fprintf (stderr, - "CB: No breakpoint found at %s for [%s]\n", + "cancel_breakpoint: No breakpoint found at %s for [%s]\n", paddress (lwp->stop_pc), target_pid_to_str (ptid_of (lwp))); } @@ -2083,7 +2086,7 @@ select_event_lwp (struct lwp_info **orig_lp) { if (debug_threads) fprintf (stderr, - "SEL: Select single-step %s\n", + "select_event_lwp: Select single-step %s\n", target_pid_to_str (ptid_of (event_lp))); } else @@ -2100,7 +2103,7 @@ select_event_lwp (struct lwp_info **orig_lp) if (debug_threads && num_events > 1) fprintf (stderr, - "SEL: Found %d SIGTRAP events, selecting #%d\n", + "select_event_lwp: Found %d SIGTRAP events, selecting #%d\n", num_events, random_selector); event_lp = (struct lwp_info *) find_inferior (&all_lwps, -- 1.8.5.1