Re: [BUILDROBOT] error: redefinition of typedef ‘record_line_ftype’ (was: [PATCH 3/6] DWARF Two Level Line Tables: check_line_address)

Maciej W. Rozycki
2015-05-28T13:58:57Z

On Thu, 28 May 2015, Jan-Benedict Glaw wrote:

> > > This patch just factors out the checking of a line address
> > > to improve the S/N ratio of the calling function.
> > >
> > > 2015-03-12 Doug Evans <dje@google.com>
> > >
> > > * dwarf2read.c (record_line_ftype): New typedef.
> > > (check_line_address): New function.
> > > (dwarf_decode_lines_1): Call it.
> >
> > Committed.
>
> Seems it's breaking, see eg. this xtensa-linux build
> (http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=442962),
> or hppa-linux
> (http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=443000):
>
> [...]
> gcc -g -O2 -I. -I/home/jbglaw/repos/binutils_gdb/gdb -I/home/jbglaw/repos/binutils_gdb/gdb/common -I/home/jbglaw/repos/binutils_gdb/gdb/config -DLOCALEDIR="\"/home/jbglaw/build/hppa-linux/_install_/share/locale\"" -DHAVE_CONFIG_H -I/home/jbglaw/repos/binutils_gdb/gdb/../include/opcode -I/home/jbglaw/repos/binutils_gdb/gdb/../opcodes/.. -I/home/jbglaw/repos/binutils_gdb/gdb/../readline/.. -I/home/jbglaw/repos/binutils_gdb/gdb/../zlib -I../bfd -I/home/jbglaw/repos/binutils_gdb/gdb/../bfd -I/home/jbglaw/repos/binutils_gdb/gdb/../include -I../libdecnumber -I/home/jbglaw/repos/binutils_gdb/gdb/../libdecnumber -I/home/jbglaw/repos/binutils_gdb/gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -I/usr/include/python2.6 -I/usr/include/python2.6 -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wpointer-sign -Wmissing-prototypes -Wdeclaration-after-statement -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o dwarf2read.o -MT dwarf2read.o -MMD -MP -MF .deps/dwarf2read.Tpo /home/jbglaw/repos/binutils_gdb/gdb/dwarf2read.c
> /home/jbglaw/repos/binutils_gdb/gdb/dwarf2read.c:17480: error: redefinition of typedef Β‘record_line_ftypeΒ’
> /home/jbglaw/repos/binutils_gdb/gdb/buildsym.h:177: note: previous declaration of Β‘record_line_ftypeΒ’ was here
> make[1]: *** [dwarf2read.o] Error 1
> make[1]: Leaving directory `/home/jbglaw/build/hppa-linux/build-gdb/gdb'
> make: *** [all-gdb] Error 2
>
> Probably just missed a small part of the patch which removed the
> second definition?

Also mips-linux; any build probably.

The typedef in buildsym.h has to stay, it's already used elsewhere.
It's the newly-added one in dwarf2read.c that has to go. Both are
identical anyway.

Maciej