From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14114 invoked by alias); 5 Aug 2003 18:06:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14099 invoked from network); 5 Aug 2003 18:06:28 -0000 Received: from unknown (HELO hawaii.kealia.com) (209.3.10.89) by sources.redhat.com with SMTP; 5 Aug 2003 18:06:28 -0000 Received: by hawaii.kealia.com (Postfix, from userid 2049) id 4A7A6BFE6; Tue, 5 Aug 2003 11:06:28 -0700 (PDT) To: gdb-patches@sources.redhat.com Subject: Re: [rfa] generate symbols associated to namespaces References: <20030622173547.GA22603@nevyn.them.org> <20030624185019.GA24662@nevyn.them.org> <20030805175429.GA29704@nevyn.them.org> From: David Carlton Date: Tue, 05 Aug 2003 18:06:00 -0000 In-Reply-To: <20030805175429.GA29704@nevyn.them.org> (Daniel Jacobowitz's message of "Tue, 5 Aug 2003 13:54:29 -0400") Message-ID: User-Agent: Gnus/5.1002 (Gnus v5.10.2) XEmacs/21.4 (Rational FORTRAN, linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-08/txt/msg00063.txt.bz2 On Tue, 5 Aug 2003 13:54:29 -0400, Daniel Jacobowitz said: > On Fri, Jun 27, 2003 at 02:58:50PM -0700, David Carlton wrote: >> + /* Allocate empty GLOBAL_BLOCK and STATIC_BLOCK. */ >> + >> + bl = allocate_block (&objfile->symbol_obstack); >> + BLOCK_DICT (bl) = dict_create_linear (&objfile->symbol_obstack, >> + NULL); >> + BLOCKVECTOR_BLOCK (bv, GLOBAL_BLOCK) = bl; >> + bl = allocate_block (&objfile->symbol_obstack); >> + BLOCK_DICT (bl) = dict_create_linear (&objfile->symbol_obstack, >> + NULL); >> + BLOCKVECTOR_BLOCK (bv, STATIC_BLOCK) = bl; >> + >> + /* Allocate the possible namespace block; we put it where the first >> + local block will live, though I don't think there's any need to >> + pretend that it's actually a local block (e.g. by setting >> + BLOCK_SUPERBLOCK appropriately). */ >> + >> + bl = allocate_block (&objfile->symbol_obstack); >> + BLOCK_DICT (bl) = dict_create_hashed_expandable (); >> + BLOCKVECTOR_BLOCK (bv, FIRST_LOCAL_BLOCK) = bl; > Is there any particular reason not to use the global block? If so > might want to comment what it is. Yes: we never want these symbols to be found by a normal search of all symtabs' global blocks, because we don't trust these symbols. We only want them found as a last resort, once we've looked every place that symbols associated to classes should live. So that's why I stash them in a local block. I'll add a comment to that effect. David Carlton carlton@kealia.com