From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27791 invoked by alias); 25 Nov 2003 17:58:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27773 invoked from network); 25 Nov 2003 17:58:34 -0000 Received: from unknown (HELO hawaii.kealia.com) (209.3.10.89) by sources.redhat.com with SMTP; 25 Nov 2003 17:58:34 -0000 Received: by hawaii.kealia.com (Postfix, from userid 2049) id 4E5E3C6B8; Tue, 25 Nov 2003 09:58:34 -0800 (PST) To: Andrew Cagney Cc: Eli Zaretskii , gdb-patches@sources.redhat.com Subject: Re: [commit] Deprecate remaining STREQ uses References: <3FC119EB.1060102@gnu.org> <3FC234C0.1000500@gnu.org> <2914-Mon24Nov2003212333+0200-eliz@elta.co.il> <3FC39747.2090007@gnu.org> From: David Carlton Date: Tue, 25 Nov 2003 17:58:00 -0000 In-Reply-To: <3FC39747.2090007@gnu.org> (Andrew Cagney's message of "Tue, 25 Nov 2003 12:54:15 -0500") Message-ID: User-Agent: Gnus/5.1002 (Gnus v5.10.2) XEmacs/21.4 (Rational FORTRAN, linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-11/txt/msg00570.txt.bz2 On Tue, 25 Nov 2003 12:54:15 -0500, Andrew Cagney said: > So, should the transformation be the strictly mechanical inline expansion: > STREQ(a,b) => (*(a) == *(b) ? !strcmp ((a), (b)) : 0) > or also include a simplification leading to: > STREQ(a,b) => (strcmp ((a), (b)) == 0) I would vote for the latter. It should be easy to do mechanically via keyboard macros, and it's how we would prefer the code to look. David Carlton carlton@kealia.com