From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3550 invoked by alias); 1 Oct 2003 19:33:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3542 invoked from network); 1 Oct 2003 19:33:03 -0000 Received: from unknown (HELO hawaii.kealia.com) (209.3.10.89) by sources.redhat.com with SMTP; 1 Oct 2003 19:33:03 -0000 Received: by hawaii.kealia.com (Postfix, from userid 2049) id F23DDC6DB; Wed, 1 Oct 2003 12:33:02 -0700 (PDT) To: Andrew Cagney Cc: Michael Elizabeth Chastain , jimb@redhat.com, fnasser@redhat.com, gdb-patches@sources.redhat.com Subject: Re: RFA: Don't include value of expression in pc-fp.exp test name References: <200310011644.h91Gifql013894@duracef.shout.net> <3F7B1D16.4010009@redhat.com> From: David Carlton Date: Wed, 01 Oct 2003 19:33:00 -0000 In-Reply-To: <3F7B1D16.4010009@redhat.com> (Andrew Cagney's message of "Wed, 01 Oct 2003 14:29:42 -0400") Message-ID: User-Agent: Gnus/5.1002 (Gnus v5.10.2) XEmacs/21.4 (Rational FORTRAN, linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-10/txt/msg00012.txt.bz2 On Wed, 01 Oct 2003 14:29:42 -0400, Andrew Cagney said: > To split hairs, I can see two cases: > - two runs within identical environments > I can see 'diff -u' reasonably working here. > - two runs within different environments > After paren stripping the results should be identical (or close two it). > For instance sizeof.exp contains various tests to check that sizes > are sane. The actual sizes found are included in the output. > That's fine since if the numbers were to change between runs the > test results are pretty sunk. That's a very good point. I've seen variants of this myself: I've seen interesting differences between test runs if I change GCC versions/debug formats, as well. For example, this can show up in tests with multiple PASS branches: sometimes, it can be interesting to know which PASS branch you hit (or, rather, if you had a change from one PASS branch to another PASS branch), so putting information in parentheses there is useful. I would be quite happy if we adopted the philosophy that the only stuff that you should put in parentheses satisfies these conditions: * It shouldn't change if the environment changes (for some appropriate value of "the environment changes"). * If it does change while the enviroment stays the same, then you want to know about it. David Carlton carlton@kealia.com