From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7316 invoked by alias); 10 Nov 2003 16:55:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7301 invoked from network); 10 Nov 2003 16:55:09 -0000 Received: from unknown (HELO hawaii.kealia.com) (209.3.10.89) by sources.redhat.com with SMTP; 10 Nov 2003 16:55:09 -0000 Received: by hawaii.kealia.com (Postfix, from userid 2049) id CA724C6AC; Mon, 10 Nov 2003 08:55:06 -0800 (PST) To: gdb-patches@sources.redhat.com Cc: jimb@redhat.com Subject: Re: [RFA/dwarf] Pass some global state around References: <20031110155049.GA23799@nevyn.them.org> From: David Carlton Date: Mon, 10 Nov 2003 16:55:00 -0000 In-Reply-To: <20031110155049.GA23799@nevyn.them.org> (Daniel Jacobowitz's message of "Mon, 10 Nov 2003 10:50:49 -0500") Message-ID: User-Agent: Gnus/5.1002 (Gnus v5.10.2) XEmacs/21.4 (Rational FORTRAN, linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-11/txt/msg00192.txt.bz2 On Mon, 10 Nov 2003 10:50:49 -0500, Daniel Jacobowitz said: > This is a cleanup that I've discussed with Jim before. We create a new > structure, dwarf2_cu, and pass it to just about everything. Primary goals: > - Move some things that don't really belong in the comp_unit_head out of > that and into the new type. > - Move global state that shouldn't be global into the new type. > The eventual goal is to eliminate most/all global state for the reading of a > compilation unit, so that we can do more than one at a time. Seems like a good idea to me - global state is bad, long argument lists are bad, and arguments that frequently get passed around together should be combined into a single data structure. David Carlton carlton@kealia.com