From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DEeWHNBAh2q8nzIAWB0awg (envelope-from ) for ; Thu, 20 Aug 2026 14:00:48 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=CPfJLLdh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5C43C1E033; Thu, 20 Aug 2026 14:00:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 503341E033 for ; Thu, 20 Aug 2026 14:00:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F34974B99F55 for ; Thu, 20 Aug 2026 18:00:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F34974B99F55 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=CPfJLLdh Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 4232D4BA9030 for ; Thu, 20 Aug 2026 18:00:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4232D4BA9030 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4232D4BA9030 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=129.70.160.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787248821; cv=none; b=sZLWC4k93NLspnGgfxbb8Q3ypzA/VKg0/JZl4614mFDUzDvIvrgSoj4BscSIciAv1iUtda+oK0RknZt8ADMi4jev36eGWb9KFyGF+RUJMXD8E+TAsF6LWw0meDItZR+4cDC6JIeJ7cdKaHj+ZaJKtM8NQkaf+ENBR5nfUCz1YOY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787248821; c=relaxed/simple; bh=0OZLuUWY4edpBWFRLp6zDj6EzgM7fCmVavImUhL8s9s=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=c0dkbNGbi456iN0CVRubKtArOCtKGZvBHHQ/bs7huwqnAAsHhG5noeDllg38CywQ7a3EqB0OqGc4I6JM2zFfqF2XC/+GplbHF2p75r4Vhb1ChU9t4Du7+wYh33E048j8V+4nedaT5c8D8IZvfrnNP7wUegvUjdczMFyHQq86inc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=CPfJLLdh DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4232D4BA9030 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 6DA3AE94E8; Thu, 20 Aug 2026 20:00:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= cebitec.uni-bielefeld.de; h=content-type:content-type :mime-version:user-agent:message-id:date:date:references :in-reply-to:subject:subject:from:from:received:received; s= 20200306; t=1787248820; bh=0OZLuUWY4edpBWFRLp6zDj6EzgM7fCmVavImU hL8s9s=; b=CPfJLLdh7KkqoMynAldXubmJpax3CwRvvc4xP1N0HSUUYL99A5rE1 aGTJz0+kAYDZIThig/AcQR0aJ3TEJMEiwEZr+VNBjXCCN56WcQ5tTdFGSdhBKyR5 neqREhO7utbz/fdmOqLYWXYiUOkCj+wZCvea13JyyQYoDv6FW5q4FK0VUK3mGKzL IE23P/WDSi3K6dgK/NUT3z3Q7GQfaeFnROLqnhvC8z4NZg7hefbisRKElsI5kkt9 p3hRM+01fvE892xe7bsgH0KEEWTeCWaEA4UfwwYjC9aTI1WgK2NW5VM2uVicqFjg OO3SboS82iLarpJye810PmVoFJ7vr0gZw== X-Virus-Scanned: amavisd-new at cebitec.uni-bielefeld.de Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id DxB9gY9qHudR; Thu, 20 Aug 2026 20:00:20 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p508553da.dip0.t-ipconnect.de [80.133.83.218]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 93AC5E94EA; Thu, 20 Aug 2026 20:00:19 +0200 (CEST) From: Rainer Orth To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Use Solaris iconv In-Reply-To: <87o6ewu4yz.fsf@tromey.com> (Tom Tromey's message of "Thu, 20 Aug 2026 10:33:24 -0600") References: <87o6ewu4yz.fsf@tromey.com> Date: Thu, 20 Aug 2026 20:00:16 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Tom, >>>>>> "Rainer" == Rainer Orth writes: > > Rainer> However, Solaris 11.4 iconv is good enough to use: enabling its use > Rainer> fixes 300+ failures. > > Rainer> Ok for trunk? > > I think it's fine, but my question here is whether gdb intends to > support versions of Solaris where this might not work. I've thought about this but decided not to care for anything but Solaris 11.4 for a couple of reasons: * Over in GCC, I've obsoleted all versions up to and including 11.3 in GCC 13. Support was finally removed in GCC 15. In all that time, I'm not aware of even a single complaint about this. * Even though GDB might well work on pre-11.4 versions, I'm certainly not going to test this. Howver, unless someone else steps forward to do so, untested support is useless IMO * Right now, without this patch, users get confusing warnings and tons of errors, so this is a massive improvement at little cost, so anyone using 11.4 benefits without further effort, rather than having to use GNU libiconv, which isn't bundled with Solaris. * Solaris iconv certainly has it's issues. However, when investigating GCC PR c++/112652, I learned that it hasn't been touched in many years, so it's unlikely that there are considerable changes since at least Solaris 11.0 15 years ago. * Last but not least, users always have the option to use GNU libiconv instead. > Rainer> - Finally, some systems do not have iconv, or are really broken > Rainer> - (e.g., Solaris, which almost has all of this working, but where > Rainer> - just enough is broken to make it too hard to use). Here we provide > Rainer> - a phony iconv which only handles a single character set, and we > > Ages ago I wrote this text, and it was true at the time. IIRC, Solaris > back then used some undocumented, idiosyncratic, system-specific wchar_t > encoding and there was no way to convert from the regular encodings to > wchar_t via iconv, or something like that. > > I don't know when Solaris changed to using Unicode. Me neither: I'd guess it was in the Solaris 10 timeframe (21 years ago now), when POSIX.1-2001 support was introduced. TBH I haven't researched since that's all ancient history now. > Anyway I guess the question I have is whether this: > > Rainer> - || (defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x108)) > Rainer> + || (defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x108) \ > Rainer> + || (defined (__sun__) && defined (__svr4__))) > > ... should check some kind of Solaris version. I guess there's no use in that. While Studio cc predefines __SunOS_RELEASE, gcc does not, so this would have to be done via a configure test. Not worth the trouble, I believe. > If not, maybe adding some note to the commit message on this topic would > be nice to have. Will do. BTW., given the benefit and no impact for other OSes, this might be a candidate for the GDB 18 release. Thoughts? Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University