Re: [PATCH] Skip gdb.dap/pauseR.exp on Solaris [PR34548]

[Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>]

Hi Andrew,

>> Here's what I came up with.  The only change on x86-64-pc-linux-gnu was
>>
>> +PASS: gdb.testsuite/gdb-caching-proc-consistency.exp: supports_target_async: consistency
>>
>> while on Solaris it fully disabled the gdb.dap tests as expected.

> Thanks for working on this.

thanks for the review.

> Other than Tom's comments, I think this looks fine.  I will note that
> the issues Tom pointed out are present in lots of the other supports_*
> procs -- not that I expect you to fix them, just noting that lots of
> this code is a little rough.

Absolutely, and this just gets copied to other cases, spreading bad
examples even further ;-)

> I'd also ask that you remove these lines from gdb.dap/pause.exp:
>
>   # PR dap/34548
>   require {!istarget "*-*-solaris2*"}
>
> at the same time as you merge this, as these are no longer needed.

Done in the revision I've just sent.  I originally meant to revert that
patch separately.

Thanks.
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University