From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39962 invoked by alias); 8 Aug 2018 14:36:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39357 invoked by uid 89); 8 Aug 2018 14:36:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=Center, racy, summaries X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Aug 2018 14:36:11 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id D7795445; Wed, 8 Aug 2018 16:36:08 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Es2d+7VqHobd; Wed, 8 Aug 2018 16:36:04 +0200 (CEST) Received: from piggy (piggy.CeBiTec.Uni-Bielefeld.DE [129.70.160.213]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with SMTP id C37AB444; Wed, 8 Aug 2018 16:36:03 +0200 (CEST) Received: by piggy (sSMTP sendmail emulation); Wed, 08 Aug 2018 16:36:03 +0200 From: Rainer Orth To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Update dg-extract-results.* from gcc References: <515bfbff-e2f7-3574-2726-ee1592786891@redhat.com> Date: Wed, 08 Aug 2018 14:36:00 -0000 In-Reply-To: <515bfbff-e2f7-3574-2726-ee1592786891@redhat.com> (Pedro Alves's message of "Tue, 7 Aug 2018 15:35:32 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00157.txt.bz2 Hi Pedro, > On 07/20/2018 12:02 PM, Rainer Orth wrote: >> When looking at the gdb.sum file produced by dg-extract-results.sh on >> Solaris 11/x86, I noticed some wrong sorting, like this: >> >> PASS: gdb.ada/addr_arith.exp: print something'address + 0 >> PASS: gdb.ada/addr_arith.exp: print 0 + something'address >> PASS: gdb.ada/addr_arith.exp: print something'address - 0 >> PASS: gdb.ada/addr_arith.exp: print 0 - something'address >> >> Looking closer, I noticed that while dg-extract-results.sh had been >> copied over from contrib in the gcc repo, the corresponding >> dg-extract-results.py file had not. The latter not only fixes the >> sorting problem I'd observed, but is also way faster than the shell >> version (like a factor of 50 faster). > > We used to have the dg-extract-results.py file, but we deleted it > because it caused (funnily enough, sorting) problems. See: > > https://sourceware.org/ml/gdb-patches/2015-02/msg00333.html > > Has that sorting stability issue been meanwhile fixed upstream? not that I can see: between the version of dg-extract-results.py removed in early 2015 and the one in current gcc trunk, there's only added handling for DejaGnu ERRORs and another minor change to do with summaries that doesn't seem to change anything wrt. sorting on first blush. Howver, I've just run make -j16 check three times in a row on amd64-pc-solaris2.11, followed by make -j48 check, and the only differences were to to 200+ racy tests, the vast majority of them in gdb.threads. Maybe the prior problems have been due to bugs in older versions of python? Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University