From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sC4OOj1eoF+bGAAAWB0awg (envelope-from ) for ; Mon, 02 Nov 2020 14:30:05 -0500 Received: by simark.ca (Postfix, from userid 112) id E108C1F08B; Mon, 2 Nov 2020 14:30:05 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C72931E58D for ; Mon, 2 Nov 2020 14:30:04 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 582EB381DC73; Mon, 2 Nov 2020 19:30:04 +0000 (GMT) Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 46A6E388A43F for ; Mon, 2 Nov 2020 19:30:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 46A6E388A43F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=ro@cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 35ACA353A; Mon, 2 Nov 2020 20:30:01 +0100 (CET) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 46oMnVAmuHp3; Mon, 2 Nov 2020 20:30:00 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4fddb2f4.dip0.t-ipconnect.de [79.221.178.244]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 6124B3539; Mon, 2 Nov 2020 20:30:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1604345400; bh=JO8GveCkksb9EgXeqVzAuX/b44PD2hnsyiU7VL4TQgM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Xxu7dSgqfu6kQk78BD4g44pDXOx9JT0d9gtn3dkBmE95wgqKEmpk/IjmYLk6rhD1A lyYqYCYgxYY/KtIy6z6LkKroldLgqWtaQYrhNQiO1IgbXppUb0Blxnbp/cJw0LcubQ 27F0XzAQ4yV1EBwwKqd2/OK6oxn3JDwE8NYCiAe8nnO2mFE4pUM31vbkFpXZ1HuZaS Dj3R4xXOliBYoLVYFxw94xpHUQcFN44QdQPoPwha3/mgDSpVeoJPG+vnGb7O38KhWA jwuAOIptAtGpwTmN2KmNtoRvnFc+P1i/wAPkkh7tJ7WhJy4qSATaiTcmoKfwMTTC8W 8xtcULWmDUjMw== From: Rainer Orth To: Gary Benson via Gdb-patches Subject: Re: [PATCH] Fix gdb.dwarf2/clztest.exp with Clang References: <1604336929-1338-1-git-send-email-gbenson@redhat.com> <87pn4vzlvt.fsf@igel.home> <20201102191402.GA6162@blade.nx> Date: Mon, 02 Nov 2020 20:29:59 +0100 In-Reply-To: <20201102191402.GA6162@blade.nx> (Gary Benson via Gdb-patches's message of "Mon, 2 Nov 2020 19:14:02 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andreas Schwab Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi Gary, > Andreas Schwab wrote: >> On Nov 02 2020, Gary Benson via Gdb-patches wrote: >> > diff --git a/gdb/testsuite/gdb.dwarf2/clztest.S b/gdb/testsuite/gdb.dwarf2/clztest.S >> > index a904fee..08a8bac 100644 >> > --- a/gdb/testsuite/gdb.dwarf2/clztest.S >> > +++ b/gdb/testsuite/gdb.dwarf2/clztest.S >> > @@ -22,6 +22,12 @@ >> > >> > */ >> > >> > +#if defined(__clang__) >> > +# define EH_FRAME_SH_FLAGS "a" >> > +#else >> > +# define EH_FRAME_SH_FLAGS "aw" >> > +#endif >> > + >> > .file "clztest.c" >> > .text >> > .Ltext0: >> > @@ -178,7 +184,7 @@ _start: >> > .LEFDE4: >> > #NO_APP >> > #APP >> > - .section .eh_frame,"aw",@progbits >> > + .section .eh_frame,EH_FRAME_SH_FLAGS,@progbits >> >> Shouldn't .eh_frame always be read-only? > > I don't know. > >> It certainly is when compiled with gcc. > > A comment in that .S file indicated it was originally generated > using GCC (via gcc -dA -S -g -O2 clztest.c -o clztest.S) but that > was 2011, so maybe things changed. > > I'm happy to change the test to have .eh_frame read-only for all > compilers, if that seems more correct. it's not: cf. EH_TABLES_CAN_BE_READ_ONLY in gcc/config/i386/sol2.h and DWARF2_EH_FRAME_READ_ONLY in gas/config/te-solaris.h and gas/config/tc-hppa.h. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University