From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WUOALzhQjWqJnj4AWB0awg (envelope-from ) for ; Tue, 25 Aug 2026 04:20:08 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=QKM4Vljq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AE7501E0A3; Tue, 25 Aug 2026 04:20:08 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 123961E09B for ; Tue, 25 Aug 2026 04:20:05 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E53634BA79A9 for ; Tue, 25 Aug 2026 08:20:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E53634BA79A9 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=QKM4Vljq Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 0A0514BA2E39 for ; Tue, 25 Aug 2026 08:19:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A0514BA2E39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0A0514BA2E39 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=129.70.160.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787645975; cv=none; b=EsqDmFhb7xXO3+NUb+d8nBpV14+7XaXr5UJQPquTrpfyZ0jRFSJDOPgtQ2sEf0onPu0ddM6+/ryyduwHUM84XsZaStyrQZzkEOVttQcQEDPcWk658OhnUsL/Vvvh3iU3qGhPoMU0mMuyMHG8imJ/5GyNDMVFFZCzSLIqsiC1h4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787645975; c=relaxed/simple; bh=EjDURyraJvD4DN2kBZ0OJiAiEY9vHSfXzZtca2jezAw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=uF/TQcAoqMCpFvZpYgmuR06WGUJB26a0AS/V39syWoFbefDk1yiJw6XzfqADyaU45Y4GT6K4LSL2YKv8hTKyYrzH+NGTQkVN6VL+rt3R5LU03LnxrFH44Z8T6udLyYKDFvvl08LTUUxQOEgWZ8lY5lufa+o9jXR8WyzcJWL2otU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=QKM4Vljq DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A0514BA2E39 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 18184F2A7F; Tue, 25 Aug 2026 10:19:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= cebitec.uni-bielefeld.de; h=content-type:content-type :mime-version:user-agent:message-id:date:date:references :in-reply-to:subject:subject:from:from:received:received; s= 20200306; t=1787645973; bh=EjDURyraJvD4DN2kBZ0OJiAiEY9vHSfXzZtca 2jezAw=; b=QKM4VljqqSTWP39HANmqiosdjD6U0cUvt8jNNx5D3dkZjFqmNeJK4 OrQRuetG5xL/iy1Zk1BfPWfYYrTzQS4/cI36ykBehj1v9OkDS2nqHAc0p2O+Ygr9 1sWHKtwk8qH5LVeVOd2moz3sZJXNB1klcLj8cp/445CSv6sRNXrXlVMzv4zOcGqp aML3CjrqI1ufn1tfTzKFvYFwR1NBnzK9q2WOo68zlDPMOnEglKTiJU1Ry4bLBRsL HgRd9TwoWalnMuVFMisu96ewZ/hhxYLW0r+ISG2FEUsbqT3jEgMzbGu/CyX+P57q mTmxgXFD/ZqvQas8DNoppljt4tJzfzybQ== X-Virus-Scanned: amavisd-new at cebitec.uni-bielefeld.de Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id oso7Cj6FfURk; Tue, 25 Aug 2026 10:19:33 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p508553da.dip0.t-ipconnect.de [80.133.83.218]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 6D339F2FB4; Tue, 25 Aug 2026 10:19:33 +0200 (CEST) From: Rainer Orth To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH] Skip gdb.dap/pause.exp on Solaris [PR34548] In-Reply-To: <874igj26tf.fsf@redhat.com> (Andrew Burgess's message of "Mon, 24 Aug 2026 10:42:20 +0100") References: <87fr07tupw.fsf@tromey.com> <874igj26tf.fsf@redhat.com> Date: Tue, 25 Aug 2026 10:19:33 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --=-=-= Content-Type: text/plain Hi Andrew, >>> So maybe DAP testing should be entirely disabled for Solaris? >> >> Like just returning 0 from allow_dap_tests on Solaris? Or doing so for >> all targets lacking async support? > > I'd suggest adding: > > # Return true for targets that support target async, > # otherwise return false. > proc supports_target_async {} { > # ... > } > > then return 0 from allow_dap_tests for any target that returns false > from the above. That would seem better than just having a selective fix > in the pause.exp file. that certainly makes the most sense. >> Here's a breakdown of gdb.dap results on Solaris: >> >> 8 ERROR >> 11 FAIL >> 713 PASS >> 8 PATH >> 8 UNRESOLVED >> 2 UNSUPPORTED >> >> I can't tell if it's still useful this way. > > I haven't checked by a lot of these passes are going to be general > boiler plate stuff. If DAP support is known to require target async ... which wasn't completely certain as far as I understood Tom... > then my personal feeling is that we'd be better just skipping those > tests on Solaris. There's plenty of testing done on other targets where > target async is supported. Right: some of them already do their own checks for async support: gdb.base/async.exp gdb.base/bg-exec-sigint-bp-cond.exp gdb.base/interrupt-noterm.exp but in those cases, async commands are a crucial part of the tests and I couldn't easily use the new supports_target_async there. There are certainly others that aren't handled yet. Besides, there are ca. 400 tests that currently time out on Solaris, massively increasing make check time ;-( I guess it's a major effort to reduce that number. >>> Rainer> This might also be a candidate for the gdb-18 branch. >>> >>> It's fine by me. >> >> Thanks. I'll way for approval from a release manager then. > > It might be worth getting the above changes made first. If you don't > have time then let me know and I'll take care of it. I've now managed to get this working, although it took me some time to wrap my head around gdb testing procedures. Here's what I came up with. The only change on x86-64-pc-linux-gnu was +PASS: gdb.testsuite/gdb-caching-proc-consistency.exp: supports_target_async: consistency while on Solaris it fully disabled the gdb.dap tests as expected. --------------------------------------------------------------------------- As detailed in PR PR dap/34548, the gdb.dap/pause.exp test runs indefinitely on Solaris. To allow make check to finish, it needs to be terminated manually. Since DAP requires asynchronous execution support, this patch checks for that and disables all gdb.dap tests if missing. Tested on x86_64-pc-solaris2.11, sparcv9-sun-solaris2.11, and x86_64-pc-linux-gnu. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34548 -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=testsuite-dap-async.patch # HG changeset patch # Parent 3fcec728f85b5d0cfef637d13368c88dad2e7bbc Require async support for DAP tests [PR34548] diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -3070,6 +3070,10 @@ gdb_caching_proc with_system_readline {} } gdb_caching_proc allow_dap_tests {} { + if { ![supports_target_async] } { + return 0 + } + if { ![allow_python_tests] } { return 0 } @@ -3908,6 +3912,39 @@ gdb_caching_proc supports_memtag {} { return 0 } +# Return 1 if target supports asynchronous execution, otherwise return 0. +gdb_caching_proc supports_target_async {} { + global srcdir subdir gdb_prompt + + set me "supports_target_async" + + set src { int main() { return 0; } } + if {![gdb_simple_compile $me $src executable ""]} { + return 0 + } + + gdb_exit + gdb_start + gdb_reinitialize_dir $srcdir/$subdir + gdb_load $obj + if { ![runto_main] } { + return 0 + } + + set res 0 + gdb_test_multiple "continue &" "" { + -re "Continuing..*" { + set res 1 + } + -re ".*Asynchronous execution not supported on this target..*" { + set res 0 + } + } + gdb_exit + remote_file build delete $obj + return $res +} + # Return 1 if catch syscall is supported, otherwise return 0. gdb_caching_proc supports_catch_syscall {} { --=-=-=--