Hi Pedro, > This all looks good to me FWIW, with a couple tiny nits below. > >> /proc file system, which is used on many versions of Unix >> as a means for debuggers to control other processes. > > Could you update this comment in procfs.c to mention Solaris > explicitly, please? Likewise the first line of the file. done, as well as in the Solaris-only proc-*.c files. >> - Examples of the systems that use this interface are: >> - >> - Irix >> - Solaris >> - OSF >> - AIX5 > > ... > >> - There are three methods for doing this function: >> - 1) Newest: read/write [PCSET/PCRESET/PCUNSET] >> - [Sol6, Sol7, UW] >> - 2) Middle: PIOCSET/PIOCRESET >> - [Irix, Sol5] >> - 3) Oldest: PIOCSFORK/PIOCRFORK/PIOCSRLC/PIOCRRLC >> - [OSF, Sol5] >> - >> - Note: Irix does not define PR_ASYNC. >> - Note: OSF does not define PR_KLC. >> - Note: OSF is the only one that can ONLY use the oldest method. >> + This function is done using read/write [PCSET/PCRESET/PCUNSET] [Sol6, >> Sol7]. > > I think the "[Sol6, Sol7]" above referred to Solaris 2.6-7. > Should we remove that? Certainly: this was used to refer to structured procfs, I believe. The following patch on top of the previous one should address all this, and John's comment as well. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University