From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4QcDC5CVnmouwjMAWB0awg (envelope-from ) for ; Mon, 07 Sep 2026 06:44:32 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=MWScdt0e; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2704A1E091; Mon, 07 Sep 2026 06:44:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0DE771E091 for ; Mon, 07 Sep 2026 06:44:31 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4DC644AA0946 for ; Mon, 7 Sep 2026 10:44:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4DC644AA0946 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=MWScdt0e Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id C9AE54C515FD for ; Mon, 7 Sep 2026 10:44:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C9AE54C515FD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C9AE54C515FD Authentication-Results: sourceware.org; arc=none smtp.remote-ip=129.70.160.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788777843; cv=none; b=OxvKVIfbwyBYMm6bc8y7LPNXMMeOTq4tFhVwm2AIo0VFu0fnwtSwOHuUMTZAuIAgJY9daeTmAduBLY0xN0g3BvvxhLxout4WyQdSMfFkyv/+mYeZoVkoZr1xlpqId+G8ETImwTf+Ley+epRccFV0lJ/pCD+yqOiX8gVB0joi9Lw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788777843; c=relaxed/simple; bh=9iKC7Bb80CyYb/s9EzHu0r3i7tsl+Y/NIk0GbcNJp38=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=M3L6NZiAUzJTjYDnKc73otvwPxL/oIcaP8RnWG/VZ1XEdwIPkxIAH4C6i4eGQZ2UPAB7OujmBFrJPbChpweOGurOBYl5yBRAcfImOi6xxnt1dS+FMoJotWVuKIIMQ/cmBebI64HuYzpx8iygz4iasnHndgLU/fSR52IOIxlTOVE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=MWScdt0e DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C9AE54C515FD Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 62E18E1721; Mon, 7 Sep 2026 12:44:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= cebitec.uni-bielefeld.de; h=content-type:content-type :mime-version:user-agent:message-id:date:date:references :in-reply-to:subject:subject:from:from:received:received; s= 20200306; t=1788777841; bh=9iKC7Bb80CyYb/s9EzHu0r3i7tsl+Y/NIk0Gb cNJp38=; b=MWScdt0eOawJ9gcTvpvCiXFp0ZWTLi1fIm9YlVUYkw5jdO8N+YNyy lWZqxg3CM+iRplxzYtGQr2V88za/LCEnwnwCd7D3IxlSl9kvPEB2uMTYLw4k2Erg tMGYKvBc1KB7ogm76P8d3pkdRn8B2qBE59ldRbSN1N2sw0uJhpCUPm9fkH/HUTcw XB8cKpmizN4uyyU0NWUbE+R245l+UiXR2M8JZuTPzFP6YL6jUeP80a8tleloDkFW 2uFeE7nnqCr9nN3fTa3MIQpZwr57p/CDubb75XgDT3A5+RoKzxenG1QVy3lozwpz pRrLO9ytpxT37/ASVoOACiOCPJWC+dh/g== X-Virus-Scanned: amavisd-new at cebitec.uni-bielefeld.de Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id e00w6WpyCIfZ; Mon, 7 Sep 2026 12:44:01 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50854206.dip0.t-ipconnect.de [80.133.66.6]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id DD737E1E8D; Mon, 7 Sep 2026 12:44:00 +0200 (CEST) From: Rainer Orth To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH v2] Require async support for DAP tests [PR34548] In-Reply-To: <87wlsxqx2u.fsf@redhat.com> (Andrew Burgess's message of "Mon, 07 Sep 2026 09:34:17 +0100") References: <87fr07tupw.fsf@tromey.com> <874igj26tf.fsf@redhat.com> <87qzjja7ta.fsf@tromey.com> <871pbdszj4.fsf@redhat.com> <87wlsxqx2u.fsf@redhat.com> Date: Mon, 07 Sep 2026 12:43:58 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Andrew, >>>> + gdb_test_multiple "continue &" "" { >>>> + -re "Continuing..*" { >>>> + set res 1 >>>> + } >>>> + -re ".*Asynchronous execution not supported on this target..*" { >>>> + set res 0 >>>> + } >>> >>> Both of these would be better written as '-re -wrap "....etc..."' adding >>> the -wrap will cause the $gdb_prompt to be matched. I don't think it >>> really matters in this case as you do call gdb_exit immediately after, >>> so I think any pending output from GDB is discarded, but it does make >>> the gdb.log a little neater, and so easier to grok. >> >> Unfortunately this doesn't work for the same reason I'd removed the >> explicit $gdb_prompt anchor >> >> -re "Continuing\\.\r\n$gdb_prompt $" { >> >> that I'd tried initially: in some cases, you get output like >> >> (gdb) continue &^M >> Continuing.^M >> (gdb) [Inferior 1 (process 3669382) exited normally]^M >> FAIL: gdb.dap/ada-scopes.exp: continue & (timeout) >> >> instead of the expected >> >> (gdb) continue &^M >> Continuing.^M >> (gdb) gdb_caching_proc supports_target_async caused gdb_exit to be called >> >> causing supports_target_async to incorrectly return 0. >> >> So that's what I'd like to check in. > > OK, thanks for clarifying. > > The usual way to handle this is to run a synchronous command afterwars, > and use that to discard any pending output, > > gdb_test "p 123" " = 123" "clear expect buffer" > > but in this case, as you immediately exit, I don't think that's really > needed. I'm happy if you just fix the other issues which I think are > still valid. that's what I'd done in the patch version attached to my last message. I've now committed the patch. Now there's only the issue of backporting it to the gdb-18 branch. Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University