From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71085 invoked by alias); 19 Sep 2018 17:42:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71065 invoked by uid 89); 19 Sep 2018 17:42:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=authors X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Sep 2018 17:42:14 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id A903F8B9; Wed, 19 Sep 2018 19:42:12 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8JYSYBD6F4v8; Wed, 19 Sep 2018 19:42:11 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p54ACFE4B.dip0.t-ipconnect.de [84.172.254.75]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id C3CF08B8; Wed, 19 Sep 2018 19:42:10 +0200 (CEST) From: Rainer Orth To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix /proc pathname sizes on Solaris References: <238c5f57-7f23-1e34-fe52-a5235a8a59d7@redhat.com> Date: Wed, 19 Sep 2018 17:42:00 -0000 In-Reply-To: <238c5f57-7f23-1e34-fe52-a5235a8a59d7@redhat.com> (Pedro Alves's message of "Wed, 19 Sep 2018 16:16:54 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00702.txt.bz2 Hi Pedro, > On 09/17/2018 03:11 PM, Rainer Orth wrote: >> * AFAIK Oracle has a corporate copyright assignment on file, so the >> patches should be covered. > > It is my understanding that an assignment alone is not sufficient. > The patches should be willfully contributed somehow too. The most > common form is by the author or representative contributing or > disclaiming it on the list of course. I wasn't aware of that. In case any of the remaining patches from the solaris-userland repo prove fit for submission, I'll check how this can be done, given that the authors are no longer with Oracle. >> Even if that were not the case, this one >> and the next are certainly below the 15-line limit for non-trivial >> patches. > > That certainly helps. On top of that, both patches clearly document the intent already: $ head 001-fix-proc-name-size.patch # # Fix the size of the pathname for /proc files. # In Solaris, PID_MAX is 999999 (6 digit pid). # In Solaris, lwpid_t is an unsigned int, so theoretically the lwp id # could be 10 digits. # Patch will be submitted upstream. $ head 007-solib-svr4.patch # Patch required for Solaris. # Will contribute upstream if possible. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University