From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101101 invoked by alias); 5 Oct 2018 09:06:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100009 invoked by uid 89); 5 Oct 2018 09:06:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 Oct 2018 09:06:35 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 04F2BD9E; Fri, 5 Oct 2018 11:06:32 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HnNQ7xhJ3Fxz; Fri, 5 Oct 2018 11:06:28 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 3B664D9D; Fri, 5 Oct 2018 11:06:28 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id w9596RLo009458; Fri, 5 Oct 2018 11:06:27 +0200 (MEST) From: Rainer Orth To: Tom Tromey Cc: Joel Brobecker , Pedro Alves , Simon Marchi , "gdb-patches\@sourceware.org" Subject: Re: [PATCH 0/8] Add -Wshadow=local References: <20180923040814.27941-1-tom@tromey.com> <29c17639-6ee6-b089-be95-227f98ac0ccf@ericsson.com> <04748d1d-0fe6-76ad-31f1-68657f8e0d56@redhat.com> <20181003175309.GB2477@adacore.com> <87k1mxf0s1.fsf@tromey.com> Date: Fri, 05 Oct 2018 09:06:00 -0000 In-Reply-To: <87k1mxf0s1.fsf@tromey.com> (Tom Tromey's message of "Thu, 04 Oct 2018 22:57:50 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00125.txt.bz2 Hi Tom, >>>>>> "Joel" =3D=3D Joel Brobecker writes: > > Joel> Coming late to the party, but fwiw, I think it's a good idea too. > Joel> Thanks for doing this, Tom. > > I've fixed the problem Simon pointed out, and I went through the patches > again. I think they are ok but I guess I would. > > I'm going to check this in now. > Let me know if you encounter any problems. this patch series broke the Solaris builds: ../../binutils-gdb/gdb/sol-thread.c: In member function =E2=80=98virtual pt= id_t sol_thread_target::wait(ptid_t, target_waitstatus*, int)=E2=80=99: ../../binutils-gdb/gdb/sol-thread.c:443:14: error: declaration of =E2=80=98= save_ptid=E2=80=99 shadows a previous local [-Werror=3Dshadow=3Dcompatible-= local] ptid_t save_ptid =3D ptid; ^~~~~~~~~ ../../binutils-gdb/gdb/sol-thread.c:432:10: note: shadowed declaration is h= ere ptid_t save_ptid; ^~~~~~~~~ Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University