From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101415 invoked by alias); 28 Sep 2017 12:40:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100663 invoked by uid 89); 28 Sep 2017 12:40:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Sep 2017 12:40:41 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 2BD4C88D; Thu, 28 Sep 2017 14:40:39 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id srWJjcYA-0Xo; Thu, 28 Sep 2017 14:40:37 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 99BB088C; Thu, 28 Sep 2017 14:40:37 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id v8SCebbX011479; Thu, 28 Sep 2017 14:40:37 +0200 (MEST) From: Rainer Orth To: Wei-min Pan Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: Fix gdb 8.1 Solaris/SPARC compilation (PR build/22206) References: <9f2fc29a-18a2-76c8-8e88-b7694ffe9f38@oracle.com> Date: Thu, 28 Sep 2017 12:40:00 -0000 In-Reply-To: (Wei-min Pan's message of "Wed, 27 Sep 2017 13:43:17 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2017-09/txt/msg00863.txt.bz2 Hi Wei-min, > As for the issues you raised on gdb ADI support for Solaris/SPARC in the > bug report, > it's never intended to add that support for Solaris. While that Solaris > provided a totally > different ADI API was a factor, for example, Linux made the information of > ADI block > size available in the ELF aux record, one needed to make a syscall on > Solaris to get that > piece of information, it's certainly doable.=C2=A0 It was never planned, > however, and most likely > will never be. this is extremely unfortunate, Oracle adding ADI support for one OS, but not for its own ;-( However, what's worse is the way in which ADI support was added: when you add code to a file shared between different OSes like sparc64-tdep.c, it's your responsibility to make sure that this code at least doesn't break other SPARC targets. Given how much of the code there isn't actually shared (and not sharable, it seems), the approach you've take seems wrong to me: it should have been properly factored between shared (sparc64-tdep.c) and os-private (e.g. sparc64-linux-tdep.c) files to avoid such breakage in the first place. Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University