From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55324 invoked by alias); 31 Jul 2018 12:44:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55312 invoked by uid 89); 31 Jul 2018 12:44:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=aside, reside, likes, messed X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Jul 2018 12:44:28 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 0CB23F80; Tue, 31 Jul 2018 14:44:26 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id VPJiosyj2F+M; Tue, 31 Jul 2018 14:44:23 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 44F91F7F; Tue, 31 Jul 2018 14:44:23 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id w6VCiMdV003180; Tue, 31 Jul 2018 14:44:22 +0200 (MEST) From: Rainer Orth To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: Update dg-extract-results.* from gcc References: <87601316fe.fsf@tromey.com> Date: Tue, 31 Jul 2018 12:44:00 -0000 In-Reply-To: <87601316fe.fsf@tromey.com> (Tom Tromey's message of "Wed, 25 Jul 2018 13:06:29 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00805.txt.bz2 Hi Tom, >>>>>> "Rainer" == Rainer Orth writes: > > Rainer> Therefore I propose to update both files from the gcc repo. The changes > Rainer> to the .sh version are trivial, just counting the number of DejaGnu > Rainer> ERROR lines, too. > > Thank you for doing this. This is ok. > > Rainer> * One could keep the files in toplevel contrib as in gcc, instead of > Rainer> stashing them away in gdb/testsuite. > > I don't have an opinion on this one, either way is ok by me. On second thought, there are some arguments for moving them to toplevel contrib: * This way, they can easily be used should someone decide to parallelize one or more of the binutils, gas, or ld testsuites. * They are less easily overlooked for updates from the gcc repo when they reside in the same place in both. * The test_summary script needs to live in contrib since the toplevel Makefile's mail-report.log target expects it there. So I'll go that route. > Rainer> * One could also copy over gcc's contrib/test_summary, used by the > Rainer> toplevel make mail-report.log to provide a nice summary of test > Rainer> results. However, this is currently hampered by the fact that for > Rainer> parallel make check the gdb.sum and gdb.log files are left in > Rainer> outputs/*/*/gdb.{sum,log} after dg-extract-results.sh has run instead > Rainer> of moving them to *.sep like gcc's gcc/Makefile.in does, so > Rainer> mail-report.log lists every failure twice. > > I don't understand the "*.sep" comment - would you mind spelling it out? The test_summary scripts works by searching for *.sum and *.log files in the whole tree (given that those live at different levels in the build tree and cannot easily be found with a glob pattern). Currently, once dg-extract-results.sh has summarized the individual gdb.sum and gdb.log files in outputs, we have both the individual per-subdir files in place and the summarized one in gdb/testsuite. When test_summary runs, it find all of of those and lists every non-PASS result twice in its output, which isn't particularly helpful. To avoid this, the gcc testsuite moves the subdir .sum/.log files for parallelized testsuites to .sum.sep/.log.sep before passing them to dg-extract-results.sh. This way, we get one summary per testsuite (e.g. gcc or g++, or gdb in the case at hand), and test_summary won't pick them up twice. > Anyway, if this script is useful to you, it's fine with me if you want > to find a way to make it work. I think the outputs/** stuff can be > moved around or messed with pretty freely, though of course it is best > not to outright lose things. Absolutely: as I said, the individual files are just moved aside not to interfere with the likes of test_summary, but still left in place since dg-extract-results.* isn't always perfect in merging them. I'll go ahead and prepare a patch then. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University