From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23253 invoked by alias); 23 Nov 2009 20:45:02 -0000 Received: (qmail 23177 invoked by uid 22791); 23 Nov 2009 20:45:00 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Nov 2009 20:44:54 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 1FC653BC; Mon, 23 Nov 2009 21:44:52 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FvaXca9n4sh4; Mon, 23 Nov 2009 21:44:50 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 0E9803BB; Mon, 23 Nov 2009 21:44:50 +0100 (CET) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.3+Sun/8.14.3/Submit) id nANKihLd002962; Mon, 23 Nov 2009 21:44:43 +0100 (MET) From: Rainer Orth To: tromey@redhat.com Cc: gdb-patches@sourceware.org Subject: Re: Fix gdb 7.0 compilation on IRIX 5.3 References: Date: Mon, 23 Nov 2009 20:45:00 -0000 In-Reply-To: (Tom Tromey's message of "Mon, 23 Nov 2009 13:19:15 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00507.txt.bz2 Tom Tromey writes: >>>>>> "Rainer" == Rainer Orth writes: > > Rainer> 2009-11-23 Rainer Orth > Rainer> * dwarf2read.c [HAVE_MMAP] (MAP_FAILED): Define if missing. > > Rainer> +#ifndef MAP_FAILED > Rainer> +#define MAP_FAILED -1 > Rainer> +#endif > > I would have expected `(void *) -1' here. This is ok if it was > warning-free. Or the other form is also ok. I didn't see the warning, and used the cast-free form since gcc had both. I notice now that they use casts to char * when MAP_FAILED is used. Could you check this in for me? I couldn't check out an rw cvs tree from sourceware.org, although I should have rw access to src. ro@manam 443 > cvs -d :ext:ro@sourceware.org:/cvs/src co gdb Permission denied (publickey,gssapi-with-mic). cvs [checkout aborted]: end of file from server (consult above messages if any) Btw, the crashes I've observed were already known: PR gdb/10819. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University =================================================================== RCS file: gdb/RCS/dwarf2read.c,v retrieving revision 1.1 diff -up -r1.1 gdb/dwarf2read.c --- gdb/dwarf2read.c 2009/09/15 16:09:32 1.1 +++ gdb/dwarf2read.c 2009/11/23 20:36:20 @@ -58,6 +58,9 @@ #endif #ifdef HAVE_MMAP #include +#ifndef MAP_FAILED +#define MAP_FAILED ((void *) -1) +#endif #endif #if 0