From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24800 invoked by alias); 26 Sep 2017 13:04:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23213 invoked by uid 89); 26 Sep 2017 13:04:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Sep 2017 13:04:41 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 1AC30C10; Tue, 26 Sep 2017 15:04:39 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ZtOee5UbhUDj; Tue, 26 Sep 2017 15:04:07 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id ED2E2BFA; Tue, 26 Sep 2017 15:02:24 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id v8QD2O8B025841; Tue, 26 Sep 2017 15:02:24 +0200 (MEST) From: Rainer Orth To: Pedro Alves Cc: gdb-patches@sourceware.org, Weimin Pan Subject: Re: Fix gdb 8.1 Solaris/SPARC compilation (PR build/22206) References: Date: Tue, 26 Sep 2017 13:04:00 -0000 In-Reply-To: (Pedro Alves's message of "Tue, 26 Sep 2017 12:33:16 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-09/txt/msg00797.txt.bz2 Hi Pedro, > On 09/26/2017 10:33 AM, Rainer Orth wrote: > >> Apart from the capitalization differences that trip g++, the names >> differ (PSR_VER vs. PSR_VERS), PSR_XCC is included in Solaris' PSR_RSV, >> and there's no PSR_V8PLUS on Solaris either. > > What you've done is fine with me to unbreak the build. Though > I'd prefer if we renamed those to avoid ever relying on host > symbols, anywhere. Like: > > - #define PSR_S ... > + #define SPARC64_PSR_S ... > > etc. agreed. That's probably best done when figuring out how to properly separate target-dependent and independent parts of ADI support. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University