From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73654 invoked by alias); 19 Sep 2018 17:44:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73644 invoked by uid 89); 19 Sep 2018 17:44:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Sep 2018 17:44:10 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id F0F168DD; Wed, 19 Sep 2018 19:44:07 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id T7ky6cNUGHOl; Wed, 19 Sep 2018 19:44:06 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p54ACFE4B.dip0.t-ipconnect.de [84.172.254.75]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 3FD348DC; Wed, 19 Sep 2018 19:44:06 +0200 (CEST) From: Rainer Orth To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Provide pid_to_exec_file on Solaris (PR tdep/17903) References: <20180919143558.GP19172@adacore.com> Date: Wed, 19 Sep 2018 17:44:00 -0000 In-Reply-To: <20180919143558.GP19172@adacore.com> (Joel Brobecker's message of "Wed, 19 Sep 2018 07:35:58 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00703.txt.bz2 Hi Joel, >> 2018-06-13 Rainer Orth >> >> PR tdep/17903 >> * procfs.c (procfs_target): Declare pid_to_exec_file. >> (procfs_target::pid_to_exec_file): New. > > Nice :). This is OK for me as is; one question: Have you considered > the use of an std::string for the variable "name"? I thought about it, > and I'm not sure it would make the code all that better, but thought > I'd mention it again, in case you or someone else sees something > I don't see. TBH, I know close to nothing about C++, so rely on others for suggestions here. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University