From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15437 invoked by alias); 9 Sep 2019 08:07:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15429 invoked by uid 89); 9 Sep 2019 08:07:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2 autolearn=ham version=3.3.1 spammy=university, University, rainer, Rainer X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Sep 2019 08:07:31 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id A9EE2692; Mon, 9 Sep 2019 10:07:29 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rioHPAc4k04f; Mon, 9 Sep 2019 10:07:28 +0200 (CEST) Received: from itzacchiuatl.CeBiTec.Uni-Bielefeld.DE (itzacchiuatl.CeBiTec.Uni-Bielefeld.DE [129.70.161.157]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 36B17691; Mon, 9 Sep 2019 10:07:28 +0200 (CEST) Received: (from ro@localhost) by itzacchiuatl.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id x8987RXG001225; Mon, 9 Sep 2019 10:07:27 +0200 (CEST) From: Rainer Orth To: libor.bukata@oracle.com Cc: gdb-patches@sourceware.org Subject: Re: Fix a crash in compile_to_object function References: <3ad99625-43ff-a450-6e50-d83242224443@oracle.com> Date: Mon, 09 Sep 2019 08:07:00 -0000 In-Reply-To: <3ad99625-43ff-a450-6e50-d83242224443@oracle.com> (libor bukata's message of "Fri, 6 Sep 2019 15:37:33 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00128.txt.bz2 Hi Libor, > On non-Linux platforms, gdb crashes when compile command is issued > because of the null pointer in struct osabi_names gdb_osab. The attached > patch adds a check to avoid this crash and adds osabi name for Solaris. > However, there is probably more work required to enable compile feature > on Solaris (e.g., solaris_infcall_munmap) and other platforms. just out of curiosity: what prompted you to try this? I gave it a very quick whirl myself, trying to run the gdb.compile/compile.exp test on amd64-pc-solaris2.11 with gdb master and libcc1.so from gcc mainline: all I got was a SIGTRAP from the very first compile command. That said, I'm quite unlikely to work on this any time soon: with ca. 2500 failures in the gdb testsuite on Solaris and even basic features unimplented (e.g. I'm currently looking into TLS support), I believe there are way more pressing issues. However, if you want to give it a try yourself, I'm more than happy to help get a patch in. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University