From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28682 invoked by alias); 29 Oct 2018 09:13:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28670 invoked by uid 89); 29 Oct 2018 09:13:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Oct 2018 09:13:10 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 6E445D45; Mon, 29 Oct 2018 10:13:07 +0100 (CET) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ZN1PCXnxkP4r; Mon, 29 Oct 2018 10:12:36 +0100 (CET) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 6B532D2F; Mon, 29 Oct 2018 10:11:44 +0100 (CET) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id w9T9BcQA004785; Mon, 29 Oct 2018 10:11:38 +0100 (MET) From: Rainer Orth To: John Darrington Cc: Simon Marchi , Sergio Durigan Junior , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] GDBSERVER: Listen on a unix domain (instead of TCP) socket if requested. References: <20181013175801.2670-1-john@darrington.wattle.id.au> <87a7nbxb2v.fsf@redhat.com> <20181019185548.izouwatbcjwnrs2a@jocasta.intra> <877eidwwlz.fsf@redhat.com> <20181028181010.yt2xlp5in65xsc4f@jocasta.intra> <20181029082435.bxgluc6zdqs5ytbq@jocasta.intra> Date: Mon, 29 Oct 2018 09:13:00 -0000 In-Reply-To: <20181029082435.bxgluc6zdqs5ytbq@jocasta.intra> (John Darrington's message of "Mon, 29 Oct 2018 09:24:35 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00684.txt.bz2 Hi John, > However I've checked in a fix for this issue, and tested it by building > natively with a hacked set of standard include headers. you always need to post patches here, if only for reference. Besides, we're currently very inconsistent here (haven't checked which part of that is due to your code): most places use AF_UNIX, only two use AF_LOCAL instead (common/netstuff.c, gdbserver/remote-utils.c), and your configure check only checks for AF_LOCAL. I believe we should canonicalize for one of the two and allow for systems that define only one or the other. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University