From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22126 invoked by alias); 4 Sep 2018 10:50:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18925 invoked by uid 89); 4 Sep 2018 10:48:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_ASCII_DIVIDERS,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=dist, vol, Hx-languages-length:773 X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Sep 2018 10:48:34 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 226FD382; Tue, 4 Sep 2018 12:48:32 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 9uF2fJGue1sY; Tue, 4 Sep 2018 12:48:01 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 75A0D102; Tue, 4 Sep 2018 12:47:08 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id w84Al72e008144; Tue, 4 Sep 2018 12:47:07 +0200 (MEST) From: Rainer Orth To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Remove cleanup from procfs.c References: <20180903190250.11599-1-tom@tromey.com> <20180903190250.11599-3-tom@tromey.com> Date: Tue, 04 Sep 2018 10:50:00 -0000 In-Reply-To: <20180903190250.11599-3-tom@tromey.com> (Tom Tromey's message of "Mon, 3 Sep 2018 13:02:48 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00048.txt.bz2 Hi Tom, > This removes the last remaining cleanup from procfs.c, replacing it > with a unique_ptr specialization. I've now regtested the patch on amd64-pc-solaris2.11. After fixing one compile failure /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:275:13: error: =E2=80=98void d= o_destroy_procinfo_cleanup(void*)=E2=80=99 declared =E2=80=98static=E2=80= =99 but never defined [-Werror=3Dunused-function] static void do_destroy_procinfo_cleanup (void *); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ by removing the unnecessary declaration, testing passed without regressions (as far as I can tell with racy tests etc.). Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University