From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2ZaLK+LGhGr4WC8AWB0awg (envelope-from ) for ; Tue, 18 Aug 2026 16:56:02 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=mdH4B5eF; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9C4461E09B; Tue, 18 Aug 2026 16:56:02 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CF92E1E09B for ; Tue, 18 Aug 2026 16:56:00 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D7A5F4BA23F6 for ; Tue, 18 Aug 2026 20:55:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D7A5F4BA23F6 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=mdH4B5eF Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id A041C4BA2E23; Tue, 18 Aug 2026 20:55:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A041C4BA2E23 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A041C4BA2E23 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=129.70.160.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787086534; cv=none; b=vJghlrzde0ofYx7hVLcvhSjstd/KtVuakifU8w9hJU2x+j5BfYsgEZkwA9DFxd1yJ1QChGND4ev01+jJOh2mAOHfTXZcXnunNp0rYWwsPtrL14xfwkYLFmji3esaY8ofQ3GTEef4ZwaFw+HZEOWg5D8R9x9yY+WixA0doKFix9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787086534; c=relaxed/simple; bh=1Ri9CJc11f9LuAXVTXA1BFD269HMZX2qOLxdqm0V5PE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Z9PYx4NQmy7Rd/JapSDYJBc6GG2cJo2fge+WoR23VcFxEU96CUd01y5lidUtTf9pnYvqmBG2H+lYyJ8HTBidNp20Zf+g/efWPkqcKqm4A/rLVtf4th8xA9WYeLydGfrgd5v8KkPE916iSfaD+R9NUTdpIraM6+8FJVA6xAdlmuc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=mdH4B5eF DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A041C4BA2E23 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id AABC4E3DA2; Tue, 18 Aug 2026 22:55:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= cebitec.uni-bielefeld.de; h=content-transfer-encoding :content-type:content-type:mime-version:user-agent:message-id :date:date:references:in-reply-to:subject:subject:from:from :received:received; s=20200306; t=1787086533; bh=1Ri9CJc11f9LuAX VTXA1BFD269HMZX2qOLxdqm0V5PE=; b=mdH4B5eF251UqoeHuJoMHuc3BOKYZ8T yOaebeFfR809vqzG7acK/WT3jQerJ6gi9YL7S8CWghIPX0jcZwQRAALEQHrMoJj4 P+HaYx0xF36WYfo+OXnS+htvs5hstkHEORJzNa6jNgUuNdMXecf2In81GbTRktap jLkZQZUCbaVp+KZkEH/ZIRp7dTLhwDauZef9K7fqtap4YO0Mv5ZKdg/yrL4lJk2c Wu2zIkPs9D/k+XUedOLF9wPHJ2MxUU6gOuMJVKqgBJ9A63XswbHbtCfX/wkdlRfM 1sPEHieh+KB3X1mOoV89uscs1RF4U+cZpRJSEzfnivs67mvmLvomhWQ== X-Virus-Scanned: amavisd-new at cebitec.uni-bielefeld.de Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id as8b2LVhX8pp; Tue, 18 Aug 2026 22:55:33 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p508553da.dip0.t-ipconnect.de [80.133.83.218]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 41B97E3DA1; Tue, 18 Aug 2026 22:55:33 +0200 (CEST) From: Rainer Orth To: Simon Marchi Cc: gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: [PATCH] include, opcodes: prefix REG_* macros in cris.h, nds32.h and microblaze-opcm.h In-Reply-To: <20260818202744.171176-1-simon.marchi@efficios.com> (Simon Marchi's message of "Tue, 18 Aug 2026 16:27:29 -0400") References: <20260818202744.171176-1-simon.marchi@efficios.com> Date: Tue, 18 Aug 2026 22:55:32 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Simon, > Bug 34537 reports: > > When building gdb with the default configure options of gdb buildbots= (which > include --enable-targets=3Dall), gdb fails to build: > > CXX microblaze-tdep.o > In file included from ../../binutils-gdb/gdb/microblaze-tdep.c:37: > ../../binutils-gdb/gdb/../opcodes/microblaze-opcm.h:101:9: error: =E2= =80=98REG_PC=E2=80=99 redefined [-Werror] > 101 | #define REG_PC 32 /* PC. */ > | ^~~~~~ > In file included from /usr/include/sys/ucontext.h:14, > from /usr/include/sys/signal.h:197, > from /usr/include/sys/procset.h:17, > from /usr/include/sys/wait.h:22, > from ../gnulib/import/sys/wait.h:28, > from /usr/include/stdlib.h:16, > from /usr/gcc/16/include/c++/16.1.0/cstdlib:83, > from ../../binutils-gdb/gdb/../gdbsupport/common-defs.h:107, > from ./../../binutils-gdb/gdb/defs.h:26, > from : > /usr/include/sys/regset.h:158:9: note: this is the location of the pr= evious definition > 158 | #define REG_PC REG_RIP > | ^~~~~~ > ../../binutils-gdb/gdb/../opcodes/microblaze-opcm.h:120:9: error: =E2= =80=98REG_SP=E2=80=99 redefined [-Werror] > 120 | #define REG_SP 1 /* stack pointer. */ > | ^~~~~~ > /usr/include/sys/regset.h:160:9: note: this is the location of the pr= evious definition > 160 | #define REG_SP REG_RSP > | ^~~~~~ [...] > Attempt to fix it by prefixing the macros with the arch name. > > I only modified the macros starting with "REG_", but there are other > macros with very generic names (e.g. "MAX_REG") that could be renamed > too (for consistency, IMO, all the macros in those files should be > prefixed the same way). Thanks for doing this: I wasn't sure how best to address this. > I couldn't build-test this patch on Solaris, but it build with > --enable-targets=3Dall on Linux. I'll give it a whirl tomorrow. Just in case, there are Solaris 11.4 systems in the cfarm for some time now (cfarm216 for sparc and cfarm215 for x86). Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University