From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56117 invoked by alias); 27 Sep 2017 09:16:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56072 invoked by uid 89); 27 Sep 2017 09:16:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Sep 2017 09:16:06 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id C4F71339; Wed, 27 Sep 2017 11:16:03 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Wi1vL0AEubz8; Wed, 27 Sep 2017 11:16:02 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 2751F338; Wed, 27 Sep 2017 11:16:02 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id v8R9G1cv015227; Wed, 27 Sep 2017 11:16:01 +0200 (MEST) From: Rainer Orth To: Wei-min Pan Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: Fix gdb 8.1 Solaris/SPARC compilation (PR build/22206) References: <9f2fc29a-18a2-76c8-8e88-b7694ffe9f38@oracle.com> Date: Wed, 27 Sep 2017 09:16:00 -0000 In-Reply-To: <9f2fc29a-18a2-76c8-8e88-b7694ffe9f38@oracle.com> (Wei-min Pan's message of "Tue, 26 Sep 2017 09:06:23 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-09/txt/msg00821.txt.bz2 Hi Wei-min, > On 9/26/2017 6:02 AM, Rainer Orth wrote: >> Hi Pedro, >> >>> On 09/26/2017 10:33 AM, Rainer Orth wrote: >>> >>>> Apart from the capitalization differences that trip g++, the names >>>> differ (PSR_VER vs. PSR_VERS), PSR_XCC is included in Solaris' PSR_RSV, >>>> and there's no PSR_V8PLUS on Solaris either. >>> What you've done is fine with me to unbreak the build. Though >>> I'd prefer if we renamed those to avoid ever relying on host >>> symbols, anywhere. Like: >>> >>> - #define PSR_S ... >>> + #define SPARC64_PSR_S ... >>> >>> etc. >> agreed. That's probably best done when figuring out how to properly >> separate target-dependent and independent parts of ADI support. >> >> Rainer >> > > Macros PSR_ICC/PSR_IMPL are not parts of ADI and were added to > sparc64-tdep.c > long before the Linux ADI project. Still trying to figure out why these two > macros, > pulled from /usr/include/v7/sys/psr.h, are causing problems now. I suspect there were changes to gdb/defs.h, gdb/common/common-defs.h or gnulib that ultimately dragged that file in post gdb-8.1. Seems I've been barking up the wrong tree for this one, sorry. Even so, the other problems with the ADI implemention mentioned both in the patch submission and the PR are certainly new. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University