From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7362 invoked by alias); 25 Nov 2018 14:55:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7353 invoked by uid 89); 25 Nov 2018 14:55:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=sk:0803633, doublecheck, double-check, H*f:sk:yddh8g7 X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 25 Nov 2018 14:55:29 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 25B08F33; Sun, 25 Nov 2018 15:55:27 +0100 (CET) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id anSssEd8DrIt; Sun, 25 Nov 2018 15:55:25 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4FDDBC5E.dip0.t-ipconnect.de [79.221.188.94]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 3E649F32; Sun, 25 Nov 2018 15:55:25 +0100 (CET) From: Rainer Orth To: Pedro Alves Cc: Sergio Durigan Junior , gdb-patches@sourceware.org Subject: Re: Breakage on builder Solaris11-amd64-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c References: <96729b3f-3568-1d41-4bb8-fbe4d037da93@redhat.com> <87sgzr6g7x.fsf@redhat.com> <87mupz6fyr.fsf@redhat.com> Date: Sun, 25 Nov 2018 14:55:00 -0000 In-Reply-To: (Pedro Alves's message of "Fri, 23 Nov 2018 16:39:07 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00398.txt.bz2 Hi Pedro, >>> And the actual commit failed with another reason: >>> >>> https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/411/= steps/compile%20gdb/logs/stdio >>> >>> ../../binutils-gdb/gdb/procfs.c: In function =E2=80=98int procfs_notice= _thread(procinfo*, procinfo*, void*)=E2=80=99: >>> ../../binutils-gdb/gdb/procfs.c:3136:41: error: =E2=80=98is_exited=E2= =80=99 was not declared in this scope >>> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid)) >>> ^~~~~~~~~ >>> ../../binutils-gdb/gdb/procfs.c:3136:41: note: suggested alternative: = =E2=80=98inf_exited=E2=80=99 >>> if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid)) >>> ^~~~~~~~~ >>> inf_exited >>=20 >> this is weird: I still see a declaration in gdbthread.h (and also >> is_running and is_stopped), which should go as well. > >That's because I meanwhile pushed this: > https://sourceware.org/ml/gdb-patches/2018-11/msg00380.html I only saw that commit after I'd sent my mail. >So before that we got a link error, and now we get a compile >error, which is expected. > >>=20 >> With just the typo above fixed, a local build on amd64-pc-solaris2.11 >> has just finished; make check running... It took me a bit to double-check, but the differences in testsuite results are within the (usual, mostly thread-related) variations. So the patch is ok with the missing parenthesis added. Thanks. Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University