Hi Simon,

> On 2020-07-29 7:19 a.m., Rainer Orth wrote:
>> It's even simpler: every configure script has code to parse
>> --enable-foo/--disable-foo and turn the result into enable_foo=[yes|no].  
>
> Ok, nice!
>
>> No: the code has been (and should remain) like this.  It allows the user
>> to override the automatic largefile detection with explicit
>> --enable-largefile/--disable-largefile options without having to change
>> the code.
>
> Ack.
>
>> I've now removed AC_ARG_ENABLE from largefile.m4.  Retested on
>> i386-pc-solaris2.11 without and with --disable-gdb, checking that
>> _FILE_OFFSET_BITS are set as expected, and amd64-pc-solaris2.11.
>> 
>> Ok for master now?
>
> When I run `autoreconf -vf`, I get a lot of changes.  Make sure to run
> it in any directory you touch that has a configure.ac and add the resulting
> changes.

I didn't use autoreconf, but ran the appropriate
autoconf/autoheader/aclocal/automake dance manually.  With one exception
(LARGEFILE_CPPFLAGS in gnulib Makefile.in) I'd gotten things right :-)

I don't usually include generated files in patch submissions, though:
they are heavily frowned upon at least over in GCC because they make
review quite difficult, espcially in a case like this where the
largefile.m4 change spreads to lots of configure scripts, obscuring the
change proper.

Does GDB handle things differently here?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University