From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94639 invoked by alias); 5 Oct 2018 15:58:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94615 invoked by uid 89); 5 Oct 2018 15:57:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=2.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,KAM_MARK autolearn=no version=3.3.2 spammy=H*r:LMTP X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 Oct 2018 15:57:57 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 6716F303; Fri, 5 Oct 2018 17:57:55 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id trO8-Dpbe4NI; Fri, 5 Oct 2018 17:57:53 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p54ACFE4B.dip0.t-ipconnect.de [84.172.254.75]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 394A0301; Fri, 5 Oct 2018 17:57:53 +0200 (CEST) From: Rainer Orth To: Tom Tromey Cc: Joel Brobecker , Pedro Alves , Simon Marchi , "gdb-patches\@sourceware.org" Subject: Re: [SPAM] Re: [PATCH 0/8] Add -Wshadow=local References: <20180923040814.27941-1-tom@tromey.com> <29c17639-6ee6-b089-be95-227f98ac0ccf@ericsson.com> <04748d1d-0fe6-76ad-31f1-68657f8e0d56@redhat.com> <20181003175309.GB2477@adacore.com> <87k1mxf0s1.fsf@tromey.com> <878t3cfra5.fsf@tromey.com> Date: Fri, 05 Oct 2018 15:58:00 -0000 In-Reply-To: <878t3cfra5.fsf@tromey.com> (Tom Tromey's message of "Fri, 05 Oct 2018 07:37:38 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00134.txt.bz2 Hi Tom, >>>>>> "Rainer" =3D=3D Rainer Orth writes: > > Rainer> this patch series broke the Solaris builds: > > Rainer> ../../binutils-gdb/gdb/sol-thread.c: In member function =E2=80=98= virtual ptid_t sol_thread_target::wait(ptid_t, target_waitstatus*, int)=E2= =80=99: > Rainer> ../../binutils-gdb/gdb/sol-thread.c:443:14: error: declaration of= =E2=80=98save_ptid=E2=80=99 shadows a previous local [-Werror=3Dshadow=3Dc= ompatible-local] > Rainer> ptid_t save_ptid =3D ptid; > Rainer> ^~~~~~~~~ > Rainer> ../../binutils-gdb/gdb/sol-thread.c:432:10: note: shadowed declar= ation is here > Rainer> ptid_t save_ptid; > Rainer> ^~~~~~~~~ > > Thanks for the report. > > If you can try the appended, that would be nice. If not, I will check > it in, since it looks reasonably obviously correct. I just tested the patch on amd64-pc-solaris2.11 (-m64 only): nothing more than the usual testsuite variations due to racy tests. Thanks. > Normally I would ask the buildbot to try it but I get: > > bapiya. buildbot try -b Solaris11-amd64-m64 > > =3D=3D=3D ERROR: You probably have an invalid builder in the list of = Try Builders =3D=3D=3D > =3D=3D=3D Please, double-check the list of available builders at =3D= =3D=3D > =3D=3D=3D =3D=3D=3D > > ... which seems incorrect to me. This is weird indeed: I've changed nothing on the buildslaves, am pretty certain that I saw runs of the Try scheduler from you before, and this must be a buildmaster error anyway. Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University