From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id B5162385ED4B; Thu, 30 Jul 2020 13:49:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B5162385ED4B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=ro@cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id B1FE9822AD; Thu, 30 Jul 2020 15:49:31 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SNCWAvxlWFiu; Thu, 30 Jul 2020 15:49:27 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4fddbb33.dip0.t-ipconnect.de [79.221.187.51]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 9B423822AC; Thu, 30 Jul 2020 15:49:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1596116967; bh=YReP6MoXJwAtYmt/OmlwWRZfyXE+W/hSFpBgwgrZZ8I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CRmfOgxiFv5SeY/nB5KnJCBjmDDyK1zZ2Jj4snwcVgAMmdQpRshOm1E+q1h9QsN+I Fs1er5+Fx0XnKQrq48DILFqetvWaotUY5sdrQz0qgw3IdwXjmnwwR1hf0aaGDZ2lKw 5hZL2ozTeu1pVPkb8yZ3GQN+yZKeO47Eu9reQyaDExN97LflklElcyD/lVfXEAHeHR t817S3R2PDQAGkUXxH5vb14ZGgsB4OE/4q15EBwnTsZdcV4OT3pDk7w4r6tF+xJ6zr rcMZHPNYsu3y4wGLtZlrHHFPlE5Ma5ZfnFPQ8mZ6XScIPTUVGPOTjkcHRgvP+1TVxt yHzEHjmgM0wMQ== From: Rainer Orth To: Simon Marchi Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Unify Solaris procfs and largefile handling References: <51f44a63-3062-39e5-14c5-ed08e32f2129@simark.ca> <5aae580e-ab2e-f008-91c6-f3b1c1f757b7@simark.ca> <169bf482-296b-737d-2a48-581d5b1d92bb@simark.ca> <4d3bf991-c0e5-2136-5935-4c4e47aadbf2@simark.ca> Date: Thu, 30 Jul 2020 15:49:26 +0200 In-Reply-To: <4d3bf991-c0e5-2136-5935-4c4e47aadbf2@simark.ca> (Simon Marchi's message of "Thu, 30 Jul 2020 08:43:37 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3790.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2020 13:49:37 -0000 Hi Simon, >>> When I run `autoreconf -vf`, I get a lot of changes. Make sure to run >>> it in any directory you touch that has a configure.ac and add the resulting >>> changes. >> >> I didn't use autoreconf, but ran the appropriate >> autoconf/autoheader/aclocal/automake dance manually. With one exception >> (LARGEFILE_CPPFLAGS in gnulib Makefile.in) I'd gotten things right :-) >> >> I don't usually include generated files in patch submissions, though: >> they are heavily frowned upon at least over in GCC because they make >> review quite difficult, espcially in a case like this where the >> largefile.m4 change spreads to lots of configure scripts, obscuring the >> change proper. >> >> Does GDB handle things differently here? > > I don't think there's a hard rule. If it makes the patch too big for sending on > the list, then it's fine for sure to not include them. If you don't want > to include > them, that's fine with my too, but in either case it's important to say > that you've > omitted them on purpose so we know it's not an oversight (otherwise I'll complain > about them missing :)). ok, will do. > Maybe it can be inconvenient for people who read the diff directly to review... I > personally use meld to review patches, so it's simple to just skip over generated > files. I'm using Emacs' Diff mode for that, which does nice highlighting. However, having to skip over large parts of generated files is inconvenient to me. > The patch LGTM, thanks. Pushed now. Thanks for the review. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University