Re: [PATCH 4/6] Implement support for SystemTap probes

Jan Kratochvil
2012-05-07T19:58:33Z

On Mon, 07 May 2012 21:53:49 +0200, Sergio Durigan Junior wrote:
> --- a/gdb/probe.c
> +++ b/gdb/probe.c
> @@ -303,6 +303,9 @@ collect_probes (char *objname, char *provider, char *probe_name,
> if (! objfile->sf || ! objfile->sf->sym_probe_fns)
> continue;
>
> + if (objfile->separate_debug_objfile_backlink != NULL)
> + continue;
> +

I do not think it should be kind-unspecific. Different probe kind can be for
example present only in .debug files and not in the main binaries.

Also I do not find great that it does not get displayed by `info probes' but
other commands still process even probes from .debug files.

Couldn't you put this conditional rather into stap_get_probes?

Thanks,
Jan