Re: [patch] `info proc ' completion [Re: [PATCH] Implement new `info core mappings' command]

Pedro Alves
2011-11-02T18:30:57Z

On Tuesday 01 November 2011 11:54:05, Jan Kratochvil wrote:
> On Mon, 31 Oct 2011 13:20:53 +0100, Pedro Alves wrote:
> > I once wrote a patch for that. /me *looks for it*
>
> Rebased and cleaned up the diff.
>
>
> > The reason I never pushed it is that "info proc" handles
> > more than one keyword at the same time. E.g.,
> > "info proc cmdline cwd" displays both cmdline and cwd
> > info simultaneously. That doesn't work if you have a
> > command per keyword.
>
> I did not know that, the doc does not mention it and such feature is very
> easily "workaroundable", I do not think it can be compared to he inconvenience
> of the current state.

I agree.

> OTOH I do not understand what is it good for when one has shell but if the
> feature is already there...

Yeah...

> + int stat_f = (what == IP_STAT || what == IP_ALL);

Extra space.

> + while (args && isspace (*args))
> + args++;

args = skip_spaces (args);

> + if (args && args[0])
> + error (_("Too many parameters: %s"), args);

--
Pedro Alves