From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4847 invoked by alias); 18 May 2012 11:28:29 -0000 Received: (qmail 4839 invoked by uid 22791); 18 May 2012 11:28:28 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 May 2012 11:28:11 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4IBSBDX025622 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 18 May 2012 07:28:11 -0400 Received: from fche.csb (vpn-9-186.rdu.redhat.com [10.11.9.186]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4IB972e015705; Fri, 18 May 2012 07:09:08 -0400 Received: by fche.csb (Postfix, from userid 2569) id 34B9A5813C; Fri, 18 May 2012 07:09:07 -0400 (EDT) To: Nick Clifton Cc: gdb-patches@sourceware.org Subject: Re: RFA: PR 14072: Include config.h before system header files References: <87aa15aijn.fsf@Gift.fritz.box> From: fche@redhat.com (Frank Ch. Eigler) Date: Fri, 18 May 2012 11:28:00 -0000 In-Reply-To: <87aa15aijn.fsf@Gift.fritz.box> (Nick Clifton's message of "Fri, 18 May 2012 11:29:48 +0100") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00675.txt.bz2 Nick Clifton writes: > I recently applied a patch to the binutils sources for PR 14072. This > patch checks that config.h has been included before bfd.h (so that the > correct #defines are set up), but this has broken the building of > several simulators. Below is a patch to fix all of these. > > OK to apply ? Looks good to me. - FChE