From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95762 invoked by alias); 16 Jan 2018 18:01:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95732 invoked by uid 89); 16 Jan 2018 18:01:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=slope, xcoff, H*i:sk:83efmpy X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Jan 2018 18:01:00 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BC888A34DD; Tue, 16 Jan 2018 18:00:53 +0000 (UTC) Received: from greed.delorie.com (ovpn-124-118.rdu2.redhat.com [10.10.124.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 708E860CA0; Tue, 16 Jan 2018 18:00:53 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.14.7/8.14.7) with ESMTP id w0GI0ma2013390; Tue, 16 Jan 2018 13:00:48 -0500 From: DJ Delorie To: Eli Zaretskii Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org Subject: Re: Compilation warning in simple-object-xcoff.c In-Reply-To: <83efmpy9xv.fsf@gnu.org> (message from Eli Zaretskii on Tue, 16 Jan 2018 19:45:16 +0200) Date: Tue, 16 Jan 2018 18:01:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00313.txt.bz2 I think that warning is valid - the host has a 32-bit limit to file sizes (off_t) but it's trying to read a 64-bit offset (in that clause). It's warning you that you won't be able to handle files as large as the field implies. Can we hide the warning? Probably. Should we? Debatable, as long as we want 64-bit xcoff support in 32-bit filesystems. Otherwise, we'd need to detect off_t overflow somehow, down the slippery slope of reporting the error to the caller...