From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-131821-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 85591 invoked by alias); 29 May 2016 17:06:15 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 85578 invoked by uid 89); 29 May 2016 17:06:14 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 29 May 2016 17:06:13 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 847A963164;	Sun, 29 May 2016 17:06:12 +0000 (UTC)
Received: from greed.delorie.com (ovpn-116-6.phx2.redhat.com [10.3.116.6])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4TH6Bjk031830	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);	Sun, 29 May 2016 13:06:12 -0400
Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1])	by greed.delorie.com (8.14.7/8.14.7) with ESMTP id u4TH6AFe023356;	Sun, 29 May 2016 13:06:11 -0400
From: DJ Delorie <dj@redhat.com>
To: Ed Schouten <ed@nuxi.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: Likely incorrect patch: remove the faulty basename() prototype from libiberty
In-Reply-To: <CABh_MKkAhDsyXGZ51zgwbMPe3EftsVvWf_fPz45QovhaBhPmww@mail.gmail.com> (message from Ed Schouten on Sun, 29 May 2016 18:36:05 +0200)
Date: Sun, 29 May 2016 17:06:00 -0000
Message-ID: <xnbn3o3ibh.fsf@greed.delorie.com>
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2016-05/txt/msg00527.txt.bz2


I think the right path to go down is to add libgen.h to the list in
AC_CHECK_HEADERS for every project that uses basename() (including
libiberty itself, and binutils, gdb, and gcc), and then everyone who
uses basename() from libiberty.h would need to include libgen.h *if*
it's found by configure.