From: DJ Delorie <dj@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
Subject: Re: MinGW compilation warnings in libiberty's waitpid.c
Date: Tue, 23 May 2017 19:37:00 -0000 [thread overview]
Message-ID: <xn60grgy9v.fsf@greed.delorie.com> (raw)
In-Reply-To: <83poezml4x.fsf@gnu.org> (message from Eli Zaretskii on Tue, 23 May 2017 22:24:46 +0300)
Eli Zaretskii <eliz@gnu.org> writes:
> Instead of making waitpid an always-failing stub on MinGW, wouldn't it
> be better to make it work on MinGW? Like this:
That's up to you, if it's target-specific. What about mingw64?
> --- libiberty/waitpid.c~0 2016-08-01 18:50:21.000000000 +0300
> +++ libiberty/waitpid.c 2017-05-23 21:19:34.302415000 +0300
> @@ -23,6 +23,11 @@ does the return value. The third argume
> #include <sys/wait.h>
> #endif
>
> +#ifdef __MINGW32__
> +#include <process.h>
> +#define wait(s) _cwait(s,pid,_WAIT_CHILD)
> +#endif
> +
> pid_t
> waitpid (pid_t pid, int *stat_loc, int options ATTRIBUTE_UNUSED)
> {
next prev parent reply other threads:[~2017-05-23 19:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 15:27 Eli Zaretskii
2017-05-19 15:36 ` Pedro Alves
2017-05-19 17:25 ` Eli Zaretskii
2017-05-20 1:28 ` DJ Delorie
2017-05-21 15:32 ` Eli Zaretskii
2017-05-22 19:38 ` DJ Delorie
2017-05-23 19:25 ` Eli Zaretskii
2017-05-23 19:37 ` DJ Delorie [this message]
2017-05-24 2:23 ` Eli Zaretskii
2017-05-24 2:26 ` DJ Delorie
2017-05-24 18:31 ` Eli Zaretskii
2017-05-24 21:36 ` DJ Delorie
2017-05-26 8:08 ` Eli Zaretskii
2017-05-26 16:30 ` Joel Brobecker
2017-05-26 17:43 ` Eli Zaretskii
2017-05-26 22:02 ` Joel Brobecker
2017-05-26 18:04 ` DJ Delorie
2017-05-27 11:16 ` Iain Buclaw
2017-05-30 17:11 ` Joel Brobecker
2017-06-06 17:54 ` Iain Buclaw
2017-06-07 12:38 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xn60grgy9v.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=eliz@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox