Re: PATCH: 2/6: Add AVX support (Update document)

H.J. Lu
2010-03-05T14:08:22Z

On Fri, Mar 5, 2010 at 2:33 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Thu, 4 Mar 2010 10:04:08 -0800
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>
>> This patch updates document for AVX support.  OK to install?
>
> Is it still relevant?
>
> I will review this anyway, in the hope that it will help you submit
> the fixed patch down the way.

Thanks. I will keep it in mind.

>> +@item x86:xstate=@var{bytes}:xcr0=@var{value}
>> +This feature indicates that @value{GDBN} supports x86 XSAVE extended
>
> It will look prettier in print if you use @sc{xsave} instead of
> XSAVE.  (The result in the Info manual is the same.)
>
>> +state. @var{bytes} specifies the maximum size in bytes of x86 XSAVE
>        ^^
> Two spaces between sentences, please (here and elsewhere in your
> patch).
>
>> +extended state @value{GDBN} supports. @var{value} specifies the
>> +maximum value of the extended control register 0 (the
>> +XFEATURE_ENABLED_MASK register) @value{GDBN} supports.  The stub should
>
> XFEATURE_ENABLED_MASK is a C symbol, so it should be in @code.
>
> Thanks.
>

--
H.J.