From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25305 invoked by alias); 30 Nov 2016 16:42:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25292 invoked by uid 89); 30 Nov 2016 16:42:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=personal X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 16:42:00 +0000 Received: from ESESSHC018.ericsson.se (Unknown_Domain [153.88.183.72]) by (Symantec Mail Security) with SMTP id B8.D0.32482.4510F385; Wed, 30 Nov 2016 17:41:58 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.72) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 30 Nov 2016 17:41:56 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=antoine.tremblay@ericsson.com; Received: from elxa4wqvvz1 (192.75.88.130) by HE1PR0701MB1881.eurprd07.prod.outlook.com (10.167.247.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.747.5; Wed, 30 Nov 2016 16:41:53 +0000 References: <1480428758-2481-1-git-send-email-yao.qi@linaro.org> <20161130111459.GG22209@E107787-LIN> <20161130163449.GI22209@E107787-LIN> User-agent: mu4e 0.9.17; emacs 24.5.50.1 From: Antoine Tremblay To: Yao Qi CC: Antoine Tremblay , Subject: Re: [PATCH 1/2] Add unit test to aarch64 prologue analyzer In-Reply-To: <20161130163449.GI22209@E107787-LIN> Date: Wed, 30 Nov 2016 16:42:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: BN3PR15CA0024.namprd15.prod.outlook.com (10.165.72.34) To HE1PR0701MB1881.eurprd07.prod.outlook.com (10.167.247.21) X-MS-Office365-Filtering-Correlation-Id: d08a0185-be19-4b29-475d-08d4193fcad1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR0701MB1881; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1881;3:DnxGYdyRPZlSTEYpFmJF2biCV+d9eUmCMevdWB5Ma7+kTdFpaQMGPDowbAsFFNnQeZAuU7oF05YlkPr0ih8vQWbCKMj18DT0+cone1MLuC4r4lAiCcshb+lqjxivy9kehCjSN5dSwUnkS3bGbr8U/mUX1lLy9DSXtb4LtNLqhVclRSr26IysXAR7mRQYQcqU0PpYC4GQ2AjSCpnsbOmarNEzlVQya1/a1IBCi3JP/wVGRRUHsytYLUn3vyTCYzPs0rZcrJ080eeAXp6BtYWf6A== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1881;25:3TxYqpfgaS6DwWnSENbvjSZZasKafCheKNTaHsbM5OMtn2QwthJTEodFuQBKCQFbi10fanVtdhklLA7POp173Pcj/NhoDCplIgvdLs5rcHTYqWy2KrUpVaxdO6izLkBG7uF34BNAZnZd+GQKMEGW5FQWTZXXaaxWgx+okTAtMYiC72LH1E18HNC6HH0OG7SfkAeVi8wRHjBzp66eBRZ+kBLDqAAGFcmEu1MPVa3cMZiOnyex/8RVWoIL6jr4ObwsJs8EU26jwTInX94bs3oD6zO0ZZSJMfTf8L+eZljxkWokxhQoH/EXdfnly060L9igLOmRCHnuaDiGq3uQrbWmXJu9EBDYu6k+871pEqLrlRmDybvwpqPvz1/HskV3iIsnY11YFxE0LPJiV3H+i3Nh+/KDarnzm9l7LNlmhlETGJWDpb+AAxHIKA8Z9lcWUhP0POSIkvNEbkunkd/Zan0YSbvMw/q5vCynRqhvmRssH95AAP2G+BpZ1YUZ6UccLHrZhAf/o8qDnLYxg5m0TLGHTXBWDqCPZjIAJMsGhWZylXFpWQSNH2juTPx3lalbjy79MEEMW7KOiRMY62kDU+8qFTP1b1bJoDPREVVLQk6Z44HS6VOguxseIY/J0fDBBSUt7TkcvZ0C+5lUjWM8t8tLvPeRh6aY1wTrWuy2YoJIS+lK4Re6eHcnF9vMRyzzF1iu4ORMYjKrY26r97nc+MGIpZtI8vk3YfcU8yvTBfVH/C7Vk/8IbDIN6N0a7K27eWhR4SV8dkED6H/vt8WDQyWFDg== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1881;31:0ll/0AlyIFALHI6C6+1K4dfzTZAm/EUHzxQYt+L7YAAsUHjRmrobKcTE5fRcFHVPM6TYzrR6bMarWKuGxC9sr5auvMD7sBaofBnw/BHu9F6Fgwr3GlSpU6Lc903G0BiXE5mVLPcgBruOFf0AwJq5xTR4CFymRRGPnBuuq1TTEvm2tp7q9NAP0zQwICBgMHV1gIHxidccgGwO+D+fq2CxMnz9YuwsKNMJjjxJS6hvXBJEp+5v5WntwUAE0nKnFml895Wf/Dn9Esoa2zcPbhrWSQ==;20:tZRIHWZLK9seUjxLmlYNAyykn7sxWwv7ucox+N6sfseqVCF0X+h7dfDJvNPJFJ9BTuvQKltDUwx+3krZIKyh1SGsF462kvjvGlPLyCFQxGiQBA+ZGahGSfgQn8b7OzrgluyxAzCWuNJPov5zD4J7rphvAjKeKpz82apmNBGiwre8+sDN7db8rIs3m412Ki8dXNovuTI39hOY1p6hPqx7+qj+aQy902W/Y1rF+To+SLIz1dUXu9utrwOfd+H5l5msC/llJZ2HQliq762lJ3MqnDQeE4g74lE7RyXnxOa3AplxeOCepwrrazvTUgsqNin6L4ZsTKGLYSCn91QLla56uy3z/C8GahMUGBRnC68y0o5pJsQ7bZK3cbLBVPqaGCVHFfKbhJMBmpttiuTaOI2pEjOS3D7/S/wP/hc9dv3JFUJH4pcJFIJWoEBVfSnH6/c8d9MAXQb3IktIkcuHq8WUM0FlvBqkEPgPi8kt096olidCR7zbRH4cQ65ntML2KC2W X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123564025)(20161123555025)(20161123560025)(20161123558021)(20161123562025)(6072148);SRVR:HE1PR0701MB1881;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0701MB1881; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1881;4:wJ7eObRwrYlmEEZ7NbKaU0dFS5aHHr/FXd6GcqThveHUEuB+kPTnqJV7vHfjy+Wonc55BbvGLBppjmsEkeWFhmbr5qqTzMf6ehEhdUOynl309JgkCW6vzjZKDR5PLcF6Yljzt42AtAMRuxLIfBypHsLwrHLmZPa6fRZAe81+2ezEtuBEA95Wuq11TrRYPkJgzAoF+LNnAAv/gw3RMtwz29y1av4M8viK1uPOAoEpxMJc+f3BtpcOF7E5aro3MVXWxl32WawBEGiGjwrqx3gbE6Q2qPs0mFLVVdCCRKnEBTH+tnwfvRrL70peN/IrM95W5Zqn+gDJTkjAeOpbBDtqAI2XnUJyxiDTErp0yqEcEIS2k+JXEBs5m+81VsQ5FY6E8iSaX1DRiA8QpuQEfPyh3AIRT0fl8hWQEkPWuMeXYz4IbCqdiINZsXrunyqw+mQCtb56HrWQyuhbEVK87HNpFaOf2DmfaM3tWwvq1rMmFD00wqvBHw6R1BFEWElCLZRSLKdE46rcxz4ufPXelu0BPC6X2EM/GylslguxDJdMmmZH3TzdtbMw4deDf1X8EFRJuNBxGPDYlF9LRBiltj7LtXIoD4oSkZCUX+4+BXLu1rE= X-Forefront-PRVS: 0142F22657 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(51914003)(199003)(189002)(54094003)(66066001)(33646002)(7846002)(7736002)(93886004)(68736007)(1411001)(47776003)(305945005)(4326007)(2906002)(6496003)(39410400001)(110136003)(39450400002)(97736004)(39060400001)(92566002)(6916009)(6116002)(3846002)(189998001)(5660300001)(2950100002)(81166006)(81156014)(229853002)(101416001)(83506001)(733004)(6486002)(38730400001)(6666003)(4001350100001)(76176999)(48376002)(106356001)(54356999)(50986999)(5003940100001)(105586002)(50466002)(86362001)(8676002)(42186005)(36756003);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0701MB1881;H:elxa4wqvvz1;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0701MB1881;23:MTpyikIc1crhE7ipBYOT/JuLziQPYGcbEVeKkc0?= =?us-ascii?Q?Rmc3CNHsKqrmDu5wx2Trj/V+AvOQouD4aNwTVgPDYNMAtvqJl3oCfEEh80Po?= =?us-ascii?Q?ktfZ9yxIkZ2uBg2PGG11D7Y18wOObim6K4w7UuFTWNAhbw7L185RsH3KjThD?= =?us-ascii?Q?9L0UBhOcw+P4RxOVTlcr2MGFTPlwA3X5I6cOYaPu0HmY2w4fuGyvJT5WMX7R?= =?us-ascii?Q?ImTGvTRPnHK+cocri+cDoML6Us7ePz/a26TgK7wDuhZLBXfFyFtx5WDVtOcH?= =?us-ascii?Q?vZkgnRWMI2J1HvMRaayqa5rRBs7QQjeazLLwzZeEWFEv61rYNXYBO4s0nQn+?= =?us-ascii?Q?o0W/ulbLeTeon0djcHK56FXmmJ4EIKZP8hCHAc+sFeaD0hg5e6fzrap8Z8Pb?= =?us-ascii?Q?0UcG/7MZirI7TiX3cNdF8PV2v+asoQuRo/BX/NMMnHuk5/NBjPH9+ah1J4+v?= =?us-ascii?Q?4Q/4AZRlbzz99asFcHAkPbMb7XkuPX8ozBS5xsveVF9ilV7RLq3uKU0A7c4S?= =?us-ascii?Q?hUGJpeSLxiLV3TGOxoDCQ0XOGbrNIVmX27pNX1HjB7rYtciONYqpZg4W4mV5?= =?us-ascii?Q?L0N3An1CK8BYAtiqsv7Eb3hkHOIAjqyh6hr34XN0ZA+auKNOwTKSG53gNQ5B?= =?us-ascii?Q?E6ixPEzjKBRCOG+DhC9csqxRv/D26Unt9Xus5R5f7kDUwolabIV9nY+i0d7g?= =?us-ascii?Q?LFHTk3ioyqO4CiWlAqHx7lULTdQJzcxPYFIPiqDka3RaRi/Nkd7gBD1rtm5R?= =?us-ascii?Q?E1fN8y3jqO4J6By8z/6KsWWu/wmN0JF4uXKhfVQgcEf4afUdv3vCNqLBDVel?= =?us-ascii?Q?XZvaMhV719t+KfFSYNpTTa6XEWi6x1OuSszDG79VxmyRpM79ou0EKJ246oWx?= =?us-ascii?Q?xli6BZ8AnSq0Hxg9nqyIJKq3N5epuE/cLlNQmcN2kzj5E20aS6fJcwMV8RXZ?= =?us-ascii?Q?ktPSU9Z5bP0Yc/7T/qiwv+ttbheoeBCRrNTptw7wJQm2v7LcHysGrmfFLbIc?= =?us-ascii?Q?3oIu1qSMSR3d/rdvhm+HuiF3AIX4inKVkc3zNrOAij+ZtZW+2IggVBeYc9l2?= =?us-ascii?Q?HTNkW4C2WDSkIlO8aeiLVSmck/4sAJ5gvwN/wOHTKaoLkiHLSz9/4fDxsOH7?= =?us-ascii?Q?xVvgVmJWyYFzNB4pjBqRwSbfQnlTuk8kFFwKi9rrMuccDIWdyekbvYmikKp9?= =?us-ascii?Q?PRa8AUb8AL8QexrWy9WaZohJ202eMNkv6qRPnIV2ihibXOg6daN7kaujTbOK?= =?us-ascii?Q?EbEDlffCTdXnj0oNyMg427iv9ROe5fqzh8kdYsTrcuQoO1tyvKUQRLmAs7KC?= =?us-ascii?Q?KqlCpDGxNMfIXIOMeo1J9b6A=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1881;6:kBLk4ANf9ik34D4/hQgpcUVZpubDwDSfkfyaCN2CVe9wpw7UoODXDd9Yz6MjcWyGWjl0d1GbHRonaRft26dfLkotYGK7/ALB2fvalKtWsfSr3qJjcpBrO2nb2eiObuzaSZcDKarLZwDQgBuSokDkeMJy0UAnpJWoOMrjONT3pJQznh+hF9HzDHHievgGeqOojviODHGyqmpO+OvZCUKYNY/faIdWcOIIRbskRV/mtSpyF1pwOjwpdOX2ZV5BdwisdmDYzZwguYpvkeL5RiCzCYIxXPSj1/9w8W2BFzFYxq7SKnCb6hYSfKOeDGGf1JJobpBFgHPz2vcfTw8AmzvZ5PZ4lwmMGvK00JpidtW1Ksb3dHV1cbKBlFXGAu+LR4926i5anzwSDhfurM6RFY2iJZkE8YL6WvjJtqZIdQYwCXIl4VRoBs1Ad86Ss18anUdvecFVjZH50d7A8yzgUM5hhw==;5:lamt2j+amx7CxSwzmRPy0VKEuxctMCv4RA3PbEUfoBjEu5aTC68z0izwxbzBj3pNn4vAmGvOlDKJIBA39jq/iZYzN98q2Er131aLDcbJEqXg0lzFl2f6jOYba6bz/hlUSZeJ89XVHRFEQ8l7LkpzXJyvB7xvxx7FGwOQqluIMYg=;24:S9Ok1vum1XoC+svpFgUa+R8L56KuRgK+KlbZrwMo9oaCkd40oet/prKVpJsQkswVeFdyYCld82v/d+x0GQC96EnWtSE0aMmPy0WwCEEanIs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1881;7:eUI/vqTv7Nm1T71Md52wB1IwKaNaOc+6UtGSqkD7Rhw1FN4z0IABqVyIf/j9uooJgoREpQf3D9t3ziCw/RHBJIbvzO/LBRkclrVBAk55pw3Ltrz1XKxYnfKqrYmxe7wI2eQhokwF/17JsMqkgeOPtCeVMRllGonKB0mp3rjCr15B0/qxvp/djdKjY1DNBFZxhqJkwVOxaJqQWaOMoES7tIt8KEtCUJ7K2ak/k+sCqjM1MmDyq2hWQVTY6g1YF0/+BxDjf4PH67hcOM3PTH+xbavD6vMbJkfyRyYG5mpDPLABTvCXDEiBwhEGTMsDUIYe+NQMi+dbUbhNj50zKo9+rvc+LA7Tb+IT8faGJienIaD3bwZp18mPjsM2CD6bzOwgUUW4yoBNrdnGmlFRRSdkm3OfiYyzu5di/7ZwQGbo4JxMv05tFakO3OgBFhRk3RDXbZG6xJufN0FzF+D5er4XXQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2016 16:41:53.4622 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0701MB1881 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg01001.txt.bz2 Yao Qi writes: > On Wed, Nov 30, 2016 at 06:53:08AM -0500, Antoine Tremblay wrote: >> >> Also I wonder if we need to specify the default constructor explicitly ? >> >> Is there a rationale for it? >> >> >> >> It's never used too, unless you apply my previous comment. >> > >> > The instruction_reader_test default constructor is never used. How >> > about using "= delete"? >> > >> > instruction_reader_test () = delete; >> > instruction_reader_test (std::initializer_list init) >> > : insns{init} {} >> >> Yes that would be more appropriate if we're going to specify that. >> >> I just wrote a patch with a C++ class and did not include explicit >> default constructors do you think we should make it a code convention to >> explicitly specify their existence or non-existence (=default, =delete) ? > > If you don't want default constructor to be used, "=delete" is useful, > IMO, which tells compiler not to generate the default constructor. The > intention is quite clear that I don't want you to use the default > constructor. > OK. > Using "=default" is not that clear. I personally prefer to write code > in an explicit way, so I prefer putting "=default" at the end. > >> >> I could not find mention of that in GCC's C++ conventions... > > IMO, using "=default" is a personal programming habit, so it is > reasonable not to mention it in C++ code conventions. OK thanks for the clarification. The patch LGTM.