From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28854 invoked by alias); 29 Mar 2017 17:54:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28439 invoked by uid 89); 29 Mar 2017 17:54:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=Hx-languages-length:712, H*RU:sk:EUR02-H, basically X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Mar 2017 17:54:53 +0000 Received: from ESESSHC017.ericsson.se (Unknown_Domain [153.88.183.69]) by (Symantec Mail Security) with SMTP id 6E.17.11640.9E4FBD85; Wed, 29 Mar 2017 19:54:52 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.69) with Microsoft SMTP Server (TLS) id 14.3.339.0; Wed, 29 Mar 2017 19:55:14 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxa4wqvvz1 (192.75.88.130) by HE1PR0701MB1883.eurprd07.prod.outlook.com (10.167.247.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.2; Wed, 29 Mar 2017 17:54:45 +0000 References: <20161129120702.9490-1-antoine.tremblay@ericsson.com> <20170127150139.GB24676@E107787-LIN> <2255ed6f-a146-026c-f871-00e9a33dfcf0@redhat.com> User-agent: mu4e 0.9.19; emacs 25.1.1 From: Antoine Tremblay To: Yao Qi CC: Antoine Tremblay , Pedro Alves , "gdb-patches@sourceware.org" Subject: Re: [PATCH 1/2] This patch fixes GDBServer's run control for single stepping In-Reply-To: Date: Wed, 29 Mar 2017 17:54:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: MWHPR1701CA0003.namprd17.prod.outlook.com (10.172.58.13) To HE1PR0701MB1883.eurprd07.prod.outlook.com (10.167.247.23) X-MS-Office365-Filtering-Correlation-Id: 38d52e02-b9d2-44ae-6a08-08d476ccb079 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:HE1PR0701MB1883; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1883;3:5fzMd7zKVUqZq+NXVuaOx85Bx0TcuFPckSq73dguWaV9CP5zcU7zGHgPYwB3l0qmyJHmomrlUrhSaX09Xghp67wsgm0r5SxV2UfB8bf/QxryHNZZOqNGMUOeyuRCAhW3ZH6ECGiL3vjdZsZz6pkVvZNT1KFeKSgLyp0+Ylqc3yZl1McSEMG0nSeym0765srn4l1CkET+AhM1A6229AltSnDD4QaelJAS+JDttRQ7gWgS3eXp8T+Lbee0TwBx7+2svR8MgoRj2yaGgFKIwg8sCk5THxSigiiLN3lcYvXgygVEYxIJDNHhTAAqRdJjm0+aZ/IS0roemXmz+v2zWD8QhA==;25:FuzVon7kQEhDIG4nbtHK38T0NWWcWs/8W2nh8LVjnnJXB9dCPm9z0FeDriPUyUz4Fp5H8ZFl/S6aPdBnxatSC8w7VSI+64ycEM6egNph4OYU49qS2w3PVQkSjcTi3+mBAA+tAianeTIdBcBXvRGazI1qiUSld7zKypMsFrXMip+VApCD6mIFKw10xGQqme7+mprZCO4+ZVtHvwL8OEtPWJIAmFmQa+fkbXIYxcsphB2/5yc4Hxgy9AOGlgT4rWLmkZgQtp+kiYszU1wPuJ7cx3BuzjGpD53ySLHGwPDyDPyHBuMZcsZYHff+vTUebrq7BYTp4TNZhnEzW3nb000/Xk3UkMgWyIeLTuJZH3I48flDjKAl1k3kPnQCdhCh7cQg2/zOfwpzGTfuiD2t4l0+4YCAeK2S2KrAzkCuqlxdVt5kiCCnVFCJSeSSwMI9jpQEcawitfHX4ZO5cgpFg0hmWA== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1883;31:Lxzu7D+My9FZGFKfZAvQTAtnVXqwpeX6gE3Lmb5c1pnWnGMdyDrqdH+3jSkkI8Vc2/MquPezUDteiXarBFDHdTlFEoC1jTCBztq6Sg48aJt18OIZnVbSpVLLzS/wRQWVCBGnqFwGk5DK3e9bCH6INi36XE9ndibSw8MgHsFVLwi06eMNtr5oKejA8axVcQ0DJmvHyHnbavm6qUhiBagK7fB3ponroAjfrN6sePT6wSGbiwVzH6rnlqNUZO96apG1;20:lAd/n+Vgezl+SKe5vdhYfCtx6rdodqSR1MfTvGz6ZvkB0agCuHFqBtUar8W9Zx1QN+2f31ZfCoooE+ddlX2ULLghK1AS5fMaq0E1vrddpB8S2LnekDE/+La8g409ueTRI0+AXeL1l/+aczafcqOmqo6N6q+W5oNjhb2h0azrHAb4GC3TkxJBo56Van+BGpWW83U1X0mFNjjvu8vJeB3H+TgipMlx3Lq8Bp74hofPRJEEhxhwm9WVTJuTwZOd8yehRadcyxag7BDeFzPX+kZgCUFd46Rfcd05G8q5zPApNAgOb+RqLde3uQxg3PRiSfjJUGEwpIfqD7d/kMC0Z1Sqrwjkxy6f9ksGKiW9JHWCn7tt1CcOzFXM+JDS8HdzVVxokePrfDj3pmoBu8ZEvlM73z6MJ2R+3QNpU3QSU7IZacUhL6a1qJJ2VmrLMFNxpK0484oTevE+VbA57f+Jy8CwwHLoRd+v51YXvmMww1Pau1oTInGHX5i5q4GbTPR2EeCW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123558025)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406075)(20161123562025)(6072148);SRVR:HE1PR0701MB1883;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0701MB1883; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1883;4:WyawaFBd93jyZS6gu+2udtFbxt7/OoVz2F8+/EglYT2RC3vKx0e6lhxwpE/uwljozDENx93Ju+oHKd0LNs4LVi68+/oAVyfEUi6Ar1l2PZHpQIz7jFUnDefo4G0sceCon9nNaWxRO+/t1rvbt5KevLnBBYhZbur0KYuruCQMUqDUi8bA7+z3ZwwwZ5MvH6yTzwyUpfmUtvNExbDbBaBXetVoOkVedd/X5O9T8u4eQXm/HhV89UKJb7nJOyMSCokjCZtd4Mu7OWxNBolWOFrNA09DzGD5u1UBGKY8eJzs/iRfV76nAeP+1147ntFe8/8vJSvxGsjGBXKTknOKVC9pNnetkxnN49SJUFGGat/gGtxIsEJkB+kXra4jvDLyFCd+rLvuIJSPkWjUGPIc5QY2csQzA6qhLeRu0IgU9KFyr2GmoTNBKJMaYINHzVR7j0fjZQ9Hg6XUlTvemc4Vksarz5qXDuUsm6T1l6+Ze3ywBlm4VlLQlcFsSjAwQHuKPrrsTWXFuQvPs2tT0F7+JiYGFvutZTVditzF8KXKZbARclyEtUMAMqxu1aPw9ELKZ7xfcTqudsd8OwlWFbOPgwX5LkXTX/Z62MCXWPMmwizcuYD800a1SLROwcUWc+2bEVxXn5iszETK2emDLmSHorqiMTQ6hyMtuA7shS3X8M2g8Ae7DRNt/o4JAmLjpHihuv4X34hCPaV1isbxK8l779eytUkKlhHrQ5LW6wAsKWvorjC3Z9nv8iUuP1OzUxQTPHDtUT4tl/YDhy/YLEcL+UT+KqlJyzcfPFc8PX0SerDVJ7s= X-Forefront-PRVS: 0261CCEEDF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39840400002)(39860400002)(39400400002)(39850400002)(39450400003)(39410400002)(93886004)(86362001)(6486002)(5660300001)(50986999)(76176999)(6666003)(229853002)(54356999)(42186005)(6916009)(2950100002)(33646002)(81166006)(36756003)(7736002)(8676002)(305945005)(53936002)(6116002)(3846002)(4001350100001)(38730400002)(110136004)(25786009)(1411001)(66066001)(6496005)(47776003)(5003940100001)(6246003)(4326008)(189998001)(54906002)(83506001)(2906002)(50466002)(48376002);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0701MB1883;H:elxa4wqvvz1;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0701MB1883;23:VIyiOUddp3/3OeKJ+rXz5JO9Z54yfeVdSZcBgmN?= =?us-ascii?Q?Fni+VYx2peepeaANMYUTI4dXC3OPVH9N3v5g0DNfsS99QLzII7vvYz2VuVcD?= =?us-ascii?Q?Y1ioJZkMuCcx796fOb1VRswh18kJj7hqFFQkRPRs+AseRRJLHl3PUxhR36pX?= =?us-ascii?Q?ckDHjaKVLOlCzN5b4WPNDH591etfbTUMLbWTE5Is2lfpyGY+2pxCSL0mwp1f?= =?us-ascii?Q?krH/tbX9cdWOxDVE7Ly3Q7iEvqFs7mTpwGI2/azIp3JEoxDP4dXShz/DNJfg?= =?us-ascii?Q?+b+Qp075y663jJK8akTxkkqp7iO1iQT/VWlSjMuhHx+cfAlnJ4WSRgbES56p?= =?us-ascii?Q?7pPeD2uibkpFbF4ShpZfT6ZJTGlOPLScjQsBOQxPzZkGLozTDTfU9L0VpJsR?= =?us-ascii?Q?AtPrM/1lAVMD3gV3PLTpLcomajtClD7r6rbwsm8DK6xAN0dnO9l8TBN2VtQR?= =?us-ascii?Q?AxkkQXoyw6ktnuvaUajR/GeqfiGySFpzB+uEbw012OFc1NtHhrfM723eMGyf?= =?us-ascii?Q?OemR+uNK1829np8n/NpgAWtoRFYhESmXtW1H5RlTNYRv64+AUZpQCeFmQ5PS?= =?us-ascii?Q?PhNEZS5sEjYpqOYl+1WxpkgZ8RaMzq+GuErJjLhDB9QQ1T50yr4EnPIPoZNw?= =?us-ascii?Q?uGSOqqA8BmuV3mAQDfXGju+JcXdq0GpMmmb59/DXZoJVW2OGzU0nd60zt2qP?= =?us-ascii?Q?bp3mhlnn3g7jWsH795YzyPUerpA3Uwv8eFhrz8jcsotlep2wH/xC4RxQv8Kz?= =?us-ascii?Q?/Z7CMfCkC2nCdtSq3BDKI1UOhuzrfaHXyPQfP1V8HWkH/4TUf858O0exsGiH?= =?us-ascii?Q?kkf57uOPfcKRYTTAhSDR3DDHzOM4pL7tdmeZHMkevYZ5PyCLIs6b0lcUN2lp?= =?us-ascii?Q?fBbQHCBvbwG7hTTwsI6/Tl+vKZBtYfvLITjzGADRh5hLn9DbTNIhi75E2bfD?= =?us-ascii?Q?zlHYxwKkfP1tS69sO6PHNLmvdwE1ypqkuAtoYBihmSYJywdlI/S6E7F5gj4u?= =?us-ascii?Q?A/CCnzD4B8KjI9jB5alsi0x5z7s8nMfv++svhOiXvC8lU3bQjuQr+8jGFYnW?= =?us-ascii?Q?J0Xlp4n4XNOgl5QoIEi8vSU10dqqZgNI/2gSmbgQCWJGJEXoP2oAYSNE1Uai?= =?us-ascii?Q?UmO5Xty0UdxwrsBDMCr6dtCAAxlyZSu3wzjirmKl347zXeZh/cAGx6g=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1883;6:DJd7PwBuVpSwRurDA++DZNqDV74hzVovqnokRHd5TjOAoZyo5Auo+0qqIs6uf9ZSFlsfKlGd4LSC8JUr0SNVnEiqOWPw1LbSm17VRH3Dq3ed2PQsgIPaJywX/dIlpoPFLlOpJZrj9pkYmUXp2+Gb5KCVV/9+G/oPDz5n5ZGJ6JuPC0Qmd4XyDJ2nle19lz13vD+eG5EfOBs3PAUaB/rH1So1AhJkyfh4Yktl7EGMy19kErTed1z5A3tb4nswIO75o59kLDv+pcYBti3I0+up1KqdfLn8PtSygvXOhCeI51suGE7KNBbwfBeytJkmN5t2TmitGlH8WPNGTlk7F73VE49BGXAxvJvn4OC44bBLBnZSy36DIAxqPB2gJZurtTWP/7cmbeuX1o4AwnXlgcnSPw==;5:Gj6Nv5LR78YlCHhfFKCh2go39kwORYZIWqHXftwcuiymOcWgzGeiJNpMxTd6sDLlCNe3ST5jpLv932QEr5uqSi0jHAtELCHGueyczcLU/hPqIa1gqkwmNK3kdPrf047tgp8rNWQkn/7tHOv7ZceRMA==;24:6aP0uLcxz1LCi+Z29MwH3a9NYYG0Kg2g/+XHcix0H7YzjidxhBxOEj1V1vHSDS/xVVtE0npWkMk0UXlvLBSF5h/jFYqVRGKw3nExd2K+Vdo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1883;7:VAAXfeAPThZ+dIToNMcgE+ljnf1jJTWfxjiunt3pxuYsITcu3FH1jDfDIrmwGOukOE6Mk/QUh4LE3aeVqKg3lsGMdIu9Pf7QeUkpIEge0qxLsCxONvOyqL50YPcIgI3o+E14F5qeIi7hhtngqsmyZ5x+cIpYXNq62sPSPgKkg91eenIwfLFbHiF3kiooYQ9Otru/Ms2gS0vcTOE56DaixQzUMkdWwpovI+MtgetF6hJEDLRwsB3yJFNEG21E8W7TLrllLQeTn8rHiajGWkunwa7VUVP4SAi27VLtD2LTUWXqsWVS0v2nUn5W4jy7/gXnhgm61o6POSPU8TWPqfKOHg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2017 17:54:45.5421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0701MB1883 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00511.txt.bz2 Antoine Tremblay writes: >> Consider if current PC is the IT instruction for example, then there's >> at least 2 next pcs inside the IT block where we will need to install an THUMB2 >> breakpoint and get_next_pcs will return that. Oops please read that "Consider if the current instruction is the CMP instruction before an IT instruction...." Basically so that we get into the arm-get-next-pcs.c:351 case... in fact now that I think of it maybe that would be OK if I were to add that check in breakpoint_kind_from_current_state also but the previous comments still apply about the possibly hackish state of this.. Thanks, Antoine