From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71170 invoked by alias); 31 Aug 2016 19:16:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71152 invoked by uid 89); 31 Aug 2016 19:16:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Aug 2016 19:16:42 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by (Symantec Mail Security) with SMTP id F9.5B.02571.6B8D6C75; Wed, 31 Aug 2016 15:16:39 +0200 (CEST) Received: from elxa4wqvvz1 (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.81) with Microsoft SMTP Server (TLS) id 14.3.301.0; Wed, 31 Aug 2016 15:16:30 -0400 References: <20160831171406.24057-1-antoine.tremblay@ericsson.com> <367f43f2-aacf-672f-5a1f-2d7b16381e85@redhat.com> User-agent: mu4e 0.9.17; emacs 24.5.50.1 From: Antoine Tremblay To: Antoine Tremblay CC: Pedro Alves , Subject: Re: [PATCH 1/2] Fix lwp_suspend/unsuspend imbalance in linux_wait_1 In-Reply-To: Date: Wed, 31 Aug 2016 19:16:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00337.txt.bz2 Antoine Tremblay writes: > Pedro Alves writes: > >> On 08/31/2016 06:50 PM, Antoine Tremblay wrote: >>> >>> Pedro Alves writes: >>> >>>> On 08/31/2016 06:14 PM, Antoine Tremblay wrote: >>>>> This patch fixes imbalanced lwp_suspend/unsuspend calls caused by the >>>>> premature choosing of another event for fairness. >>>>> >>>>> select_event_lwp would switch the event before a call to >>>>> unsuspend_all_lwps, thus it would be called with the wrong event. >>>> >>>> Hmm, that does sound wrong. >>>> >>>> Patch LGTM. >>>> >>> >>> Thanks, pushed. >> >> Could you push it to 7.12 as well? >> > > OK, pushed to 7.12 > >> I wonder whether this might fix: >> >> https://sourceware.org/bugzilla/show_bug.cgi?id=20176 >> > > I hope they will retest. BTW I always wanted to do this but never get to it, but it seems to me that it would be nice to have a --fatal-asserts flags in GDB that would create a core on assert. That way we could get a backtrace of the assert and know if we fixed a particular issue like this case. Regards, Antoine