From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38072 invoked by alias); 25 Nov 2016 13:57:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38053 invoked by uid 89); 25 Nov 2016 13:57:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=tracepoints X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 13:57:35 +0000 Received: from ESESSHC002.ericsson.se (Unknown_Domain [153.88.183.24]) by (Symantec Mail Security) with SMTP id 30.E8.03096.C4348385; Fri, 25 Nov 2016 14:57:33 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.24) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 25 Nov 2016 14:57:31 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=antoine.tremblay@ericsson.com; Received: from elxa4wqvvz1 (192.75.88.130) by HE1PR0701MB1882.eurprd07.prod.outlook.com (10.167.247.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.761.5; Fri, 25 Nov 2016 13:57:27 +0000 References: <1467295765-3457-1-git-send-email-yao.qi@linaro.org> <20161121120822.GA28605@E107787-LIN> <20161124215510.pbsobdtj6niycjhd@localhost> User-agent: mu4e 0.9.17; emacs 24.5.50.1 From: Antoine Tremblay To: Pedro Alves CC: Antoine Tremblay , Yao Qi , Subject: Re: [PATCH 0/9 V3] Use reinsert breakpoint for vCont;s In-Reply-To: Date: Fri, 25 Nov 2016 13:57:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: BN6PR22CA0045.namprd22.prod.outlook.com (10.173.23.31) To HE1PR0701MB1882.eurprd07.prod.outlook.com (10.167.247.22) X-MS-Office365-Filtering-Correlation-Id: a9e02da4-80e4-40f5-c3e0-08d4153afe8d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR0701MB1882; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1882;3:Drlzihlao3RL3C4Vs0EY2mz59O0qZFcXqHqKtHaMl/0VxpiKuUSP2Rr9QACt+OXn2mnWOwmL6SzhYtUE2CwjL9D2Rl7nwyEd4tNwgCotfwStyXAdz1nbAsxIBIO3YhfRfWdSJPRNtd8zx2YHdL2+udEZr3fSBDYaSvLmgaTBFdRNgxWMR0b8fb7c53vQ27RsD3IEMXV1c2n4C4qUxGpjuBs5Hz6Z5cwTbwdCAaK9qV+1dTFDvRdK/jLXDuoRnzYQAcx2Ske10uNC1edSl5BMCQ==;25:Bg2i9jMurMFUm8/xJJINUZbiy9U0+4VprIJeq8bwMaM4LUuMM4q1n9ImEnPR1RhNAxLeO4n/TnLe3fOVvUpqHYN1sB43QRgWF8guBaqw1BYS2ofaMkKdphqoS/HPHNps9Z58uxb/kV5KYPDBlf/M1DQ6ZHATT5uIE6qWq9QGzHwjdF6vwQ0oDbN7J2fGmAU+JDSwgmLc+Umq9Sp94j45qPEdvxTdd3lT8TRKqrTs58Favzlk9kaCYsEDaC67XEuVApbPy7UY2b2Kz5kkw3WWV7V8GLw9q/fZ9Wjvdo6HIr2aPd7ql912sxY2xEppuvIpMhgjA25eVM130TNr+k3KS5AjPGqYe6JLC9rKskCbG9lVk1Qh8fpsFFB5IYAtziIQPgAdyO42QmXXptg6Bqq6Rq6TNAPSp5TBfdqqlMbS4Zb5wpLoBdR51Qllcwx1IVsJ2GbUaTAy22nvU6ic0EDGdA== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1882;31:0efwGrkvEyCNDiwHAhy5nWT+WU1FLdKVc9F0xN7A5llHJDvMtr4Sd9NbgOux+2zWIMeqiKDcDPuOpjfSyua5TLkGeAVj8+1sfTl9c/KeYQ7yF6PcZI0zDQueyad8FuwT19waeMZqbRbZf+hosaL0Oy8XIzx9m4FIGUKFGDD22E5rxkTiVYqJaw0T2LnAkZ63j9Ax9HHDYQXD5dfzA4iwlcsz2tC1IM7wghySaT8Cp2owiqKT53UPTmFoN8wQ1OMElhsARYRfZX9naXexXzE24HWP968jAc/ktQpYap+O5Yg=;20:7UcsWu75pDUpxn95iosn7uzrvSReHcIWClIMUYeVXvsXXy+iYc0RWGm8WXmEJSaszfX17avoiHyjRZlIPliiwGY5DlcDeoQD8rBmQCIv5NkPIwpGzIpg56VXxn6Gw0UDWqhGHQwLCjpk6TcIAANyTYng4BmwGLoSGpQFap/Bez5u7/i5VJpC0LAf2ryiYOLaeecAuu3m/l13zLYqH9hzVFUlTusQsIkAq+Chswn4knqbnduQ4YQzZ3uzGGsxkDPcDgbAFrw91nobPAL3ZetOC3Lk7o1mYxpkr18L/iwhN+g2vce5aoigY6r3Xw4y8HxtYyiSPa4IhUrGAzbUASphvSJnzsPOruiiWdZk6kOFLfuGShm4mTQpCFZK1py4QYwBfj/G2OVHEgqL2AAEQbJ1wzk3+R29yhx7noQNfkixbspq2VJ9e+I/sDLuI2JLopEK7lyndIElJsxmkem1LoUn/PmPcy/LXPo6PGQvexxa2jIfLDCdQyXOPZjiHnnWj2ye X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6045199)(6040361)(6060326)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(6061324)(20161123555025)(20161123560025)(20161123564025)(20161123562025);SRVR:HE1PR0701MB1882;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0701MB1882; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1882;4:AHe5mPgl/V4RChiGb1r3COOTgC/PRInFeNUw6tcMS60LH5DniDFGpD4/oXUb1zJ4BoDzLAEA9e1zNv3lco6ahIuhuGRIQK9t17JNecqfEW11UGehcejgRd8bpT3vej2WngKOxOLkc/T7pHphClc/BisMhxMKyTnC+3SXI6giRxLuHR16wSx/8IHrMvIrO4SeuLUQ4toa9ZZpbE0M13jJN4z4ZnBmVVRJLsvqj7VD166qlxDosZq65o+voEs3YQjYr73k1gUE6+LLRyTf5Y50WYF0Ut9T5Ts4C/DmfEF6Bd0VD35/Fj+aAQXzSxdWkVf8g3V0Die/0N2JFAL4d5ZK007K8gOWtaIbnhR7t59EzBynN8sb/cPhhwj2uHlNJt6sJN7JM0P1sPBoOAvcUt6/A1X0ZH9+4d9RCIMM4Im+5XWJcwMXvBq2zXJCqPlw+OZz8nocvOYJ2c0dgQ8fWk7NhXLi3yRbpQ5qc//TqI3IB8ksIFi7Rz9ADJmhE63cUp2dYykn1UptTpMOdiXrdpmicrFPPhvlZca6Tm6xc+Q4IIyildcJJtNZnFLZvQdGhE21UnL/wmaglE05xpSlQ1V+kzLvlmWEK2LnQ5NJONxVRBM= X-Forefront-PRVS: 01371B902F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(199003)(377454003)(189002)(86362001)(101416001)(110136003)(189998001)(5660300001)(229853002)(50986999)(2950100002)(6916009)(5003940100001)(76176999)(6666003)(54356999)(66066001)(36756003)(47776003)(2906002)(97736004)(106356001)(93886004)(33646002)(105586002)(4326007)(39450400002)(92566002)(83506001)(6116002)(8676002)(39380400001)(39410400001)(68736007)(305945005)(7736002)(48376002)(81156014)(81166006)(39400400001)(4001350100001)(7846002)(3846002)(50466002)(77096005)(38730400001)(39060400001)(42186005);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0701MB1882;H:elxa4wqvvz1;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0701MB1882;23:5E0CAhwW4Nu2SWsbagSIEU+IA59G2oI6pl8+rxW?= =?us-ascii?Q?pUQSuqjb0/Osb8CMiFJEHn+Xeoo8Ktfn1mfYoVmeQRkSKPcm1x18fChz3T5e?= =?us-ascii?Q?LQgvc91oyqJpbdYroZseWPdz304458z9wv0mHHTJD5sJ+4TLXfTYx+K0Iqd7?= =?us-ascii?Q?eH1lysRW94QCnXsYBQkFoudgyBk6IyV2hRBItxfyNEB5Jf26eXIhjeSpgjbT?= =?us-ascii?Q?FE+Vz+Feu7RKxU1CwDI1+vKTANIWc0z4lCh06aLYtpxkNpoRFDdbG4OK9Syr?= =?us-ascii?Q?RhX8y8fttyKdVlHhkStpEAymOa6cArpPZKVYVw9NwjKn0wIakgOaq5LOwsK9?= =?us-ascii?Q?eISRQq4+zu4XZfShUVSvl7TRFmX6FFEx1z9QzQuRRnULPtjqX6ARgcjENTPG?= =?us-ascii?Q?NLv/ytgGh4bUPcRIOaZkCvY4MKGeafmqmgdohe0JA32EUhVpqqzF22zdHyxT?= =?us-ascii?Q?67AKqxkhkpBFlzDC7mJ22mge27SlM3/DNIU+/lgPuafV68AYprzPC4zyK8Y8?= =?us-ascii?Q?LoRzJAJyD3B9d891eUsPCJNrg1jk6rXDcl0YotdJ8WQ0tS+pFaa69XubRRgO?= =?us-ascii?Q?BJoYO4QJUZn7XoGe6vb2Q3QD9bPN9mlz9LdYYyffkX8AsOxj2hHy5EMabDiW?= =?us-ascii?Q?0ICrnvBwwnEjayh8/xQ5IlKfG+XBCSSDJasyKBwiqc9y60R1A7WmRxgDypEU?= =?us-ascii?Q?NLT2VOBXUuwBFBvBuBnviElKkJja14qjMD1sfyJmxsdcnk3KNs/+rAsLZMCD?= =?us-ascii?Q?b9Gq7TW/PIsXBgNIOhosQrYB0Z0BBc0THbvQZeVgYx5aahqQ24KTQnb/sls5?= =?us-ascii?Q?2/EiMLwEGQDxdoVB1NS2W0FBsS6AYZXp9J/3H/iCKWLlafL8Ido4OtYJnmAD?= =?us-ascii?Q?CwV1NP3HPF1f/YaBemqK6airuQDYhNNDwf+JX1+LwE1oPDQ2EmlzFVMNfpxS?= =?us-ascii?Q?VsvpeIQo4naN2bHBOpRbeSYf7QeqmafE+3xwvFRNTKkWnQQ0SCisDmkoGgAk?= =?us-ascii?Q?O7usUB+x5ThrtEJ3kaYVUDG/0U8dG4/K6K2JB63Exb2Woc+clG06U3hbFSiF?= =?us-ascii?Q?phJz9wr4ia43sFJunuA9HUZNhPVsqq1mpfeEFHoKYg8PXLAVaMO6UNsQsEWk?= =?us-ascii?Q?b564q00Gq/YBjtpge1yjbVR6fMKKe56uxNkWIO2MQuN+O8LIPmdWZQURFPg1?= =?us-ascii?Q?XXors23KXZsKyz83jn2U59gouQEWTtQdYp8b+xR3W0mHKaAxnXTgDXLLEdIq?= =?us-ascii?Q?IA/vzcdze7ZktNMStscpHAV95sqI8TrWB7aDgWXm8eyqGQ4AZL1k3MSjCfpy?= =?us-ascii?Q?hhQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1882;6:puvq6twFVjqyMczlrGKTKoqTTzN8mbuXICUm9d2Zh4GBVVJ3nA14Ny0NsBx4ZhXJNOiSE6iF2T7Jmv32hvpGzM2JjQ245zFhRvlrHV7iCW1OVPzI/Xg+zutHfdql69/hNRku5OBiJbIbtyjag1Y6BB4VVAWOd6lfhJtq5ZlcJFan9zNAqGFMigXN/ssmkaFi+zx4o5qWihFDxX58Gv1xExUeMRiKyIxOIZgH9nwFpm3ybIvzrnoa8pOOd7tCJFQ80n85FmCexHgkskJSYYJFtrt3rmvdbGNSXBjOdPU+6VatCEisBEYQFtSeyaZTCmY0w8e0CWKRArWtPoIK1GP3JqLw+IBD7MGec516C7X9BbRuPwZloOWwXYQIcSAYsfUdD8qky22cv6bN52HURMfSYjrmjJv20bpWmmSkyuOTDzZUZnc6B6F89LzI8YU2N5O2L2LSPe/h6qdA3dcDP9Coew==;5:kcIsSu21T5zTFJ5jQ8/hmrikfvrQehtveCOoyDzkcLSTuWokps1cRgz5en1MlYM9E3jrwQNANfeiLWZoyqQjZHoXAYiha5LbgnQN7VPJ/8NYbB95mqNsaM8e/+JiWyQBqPCnfR43e553EPzD0ChFhUqK7K46x0V3Eqe54a4/00s=;24:+Z/SPy0VUamB6L338X2tXM+++ZY4UWMymhy3Z3ZFxg0xr/wRQ2Zs/073HBnWiw2G6q4PJIEIcfdE8Yzbj14RUxoJG9EYB6MW7ghqL885hxg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1882;7:ie3s0Wjb/besxeWWJB4aSv0snX94GrUmZtBZmkJGmwcSEoeIO7glJyXJTL24sJNjHfrbVtRlc2UsK/kfE340fIgDOv/EzEARJjRU4VHUup1EvFWJKxt+gKnfdwnC9SzsOoCH+X2dlCoFsMDZzoxoXbwoFq+cdokXGPgxn8DCQX8Kc72FKY6eUDk6O1vaevhbjfwQCrAwtWhvkysoSmgm1OoJJ7n4l6YIP9R4df9oVkKtnTW+Uu+yzk4lw9ZLlreJSDQbCevrwkjENQtTTCfBUYDmLgKcbeEWU6ZWTIQXXtSwcmPSeKGNiJDjiDI7M1b8LJ1xqyhboHB9L9gPeMRvnoClKCbdhDIJ9gW4bnBsNbyADhiiCD3rqh1kZsPi3hMeon/t3aQyVVP0Jsj3WUc1+QhBt9pHw5yI6HdblGvZ8+be4L7i81zBJwc1Vn2pG1hIwUPEUawBgy2PEl25xkU4ng== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2016 13:57:27.9934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0701MB1882 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00807.txt.bz2 Pedro Alves writes: > I'm behind on this whole discussion, but, the comment below > caught my attention: > > On 11/25/2016 01:12 PM, Antoine Tremblay wrote: > >> In fact thinking more about this we may need to remove all breakpoints >> at any pc since get_next_pc may read memory in other places then the >> current pc to deal with atomic sequences for example or for other >> instructions too. >> >> If it reads a breakpoint in memory there it may come-up with an invalid >> next pc. > > How can that happen, given gdbserver's memory read routine takes > share to hide breakpoint breakpoints? > > I.e., read_inferior_memory -> check_mem_read. > Indeed, this is because arm_get_next_pc uses (*the_target->read_memory) directly. This should be fixed for read_inferior_memory indeed and it would solve this issue, sorry I was not so familiar with the check_mem_read hiding breakpoints/fast tracepoints jumps. I'm not sure why it uses that directly at the moment, looks like a plain misstake but I'll dig a bit more. But it's just what we need this may easily fix that issue in particular! Thanks, Antoine