From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55449 invoked by alias); 19 Feb 2016 16:33:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55249 invoked by uid 89); 19 Feb 2016 16:33:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=tracing, H*r:0500, Hx-languages-length:1505 X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 19 Feb 2016 16:33:09 +0000 Received: from EUSAAHC001.ericsson.se (Unknown_Domain [147.117.188.75]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id 21.04.12433.4DF37C65; Fri, 19 Feb 2016 17:16:20 +0100 (CET) Received: from elxa4wqvvz1 (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 19 Feb 2016 11:32:53 -0500 References: <86egcineq0.fsf@gmail.com> <1455547546-28825-1-git-send-email-antoine.tremblay@ericsson.com> User-agent: mu4e 0.9.17; emacs 24.4.1 From: Antoine Tremblay To: Antoine Tremblay , CC: Subject: Re: [PATCH v2] Enable tracing of pseudo-registers on ARM In-Reply-To: <1455547546-28825-1-git-send-email-antoine.tremblay@ericsson.com> Date: Fri, 19 Feb 2016 16:33:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00609.txt.bz2 Antoine Tremblay writes: > In this v2: > Use user_reg_map_name_to_regnum. Oops this is actually wrong. I forgot that the reason I had it as : + /* Single precision pseudo registers. s0-s31. */ + if (reg >= num_regs && reg < num_regs + 32) + { + rawnum = (reg - num_regs) / 2 + 26; + } + /* Quadruple precision pseudo regisers. q0-q15. */ + else if (reg >= num_regs + 32 && reg < num_regs + 32 + 16) + { + rawnum = (reg - num_regs - 32) * 2 + 26; + } In order to map from the GDB internal regnum to a real regnum to be used by GDBServer in gdbserver/ax.c as : case gdb_agent_op_reg: /* Flush the cached stack top. */ stack[sp++] = top; arg = aexpr->bytes[pc++]; arg = (arg << 8) + aexpr->bytes[pc++]; { int regnum = arg; struct regcache *regcache = ctx->regcache; switch (register_size (regcache->tdesc, regnum)) Here regnum is expected to be the real register number. As example if I get arm_pseudo_register_to_register with register 109 This is actually register 35, but user_reg_map_name_to_regnum will still map it as a GDB internal register number 67. It's 32 regs off because user_reg_map_name_to_regnum iterates over all regs as num_regs + pseudo_regs, and in this case num_regs is 91 since in arm.h the regnum enums gives a GDB internal register number so that all registers numbers are unique independantly from the arch in use. Maybe there's a better way to map these internal gdb registers to actual register numbers ? Yao?