From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40362 invoked by alias); 19 Feb 2016 20:32:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40340 invoked by uid 89); 19 Feb 2016 20:32:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=H*r:0500 X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 19 Feb 2016 20:32:03 +0000 Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id CA.02.12433.0D777C65; Fri, 19 Feb 2016 21:15:12 +0100 (CET) Received: from elxa4wqvvz1 (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.78) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 19 Feb 2016 15:31:55 -0500 References: <1455910116-13237-1-git-send-email-antoine.tremblay@ericsson.com> <56C7796B.3030504@redhat.com> User-agent: mu4e 0.9.17; emacs 24.4.1 From: Antoine Tremblay To: Pedro Alves CC: Antoine Tremblay , , Subject: Re: [PATCH v3] Enable tracing of pseudo-registers on ARM In-Reply-To: <56C7796B.3030504@redhat.com> Date: Fri, 19 Feb 2016 20:32:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00625.txt.bz2 Pedro Alves writes: > On 02/19/2016 07:28 PM, Antoine Tremblay wrote: > >> +/* Map the pseudo register number REG to the proper register number. */ >> + >> +static int >> +arm_pseudo_register_to_register (struct gdbarch *gdbarch, int reg) >> +{ > >> + /* Get the remote/tdesc register number. */ >> + double_regnum = gdbarch_remote_register_number (gdbarch, double_regnum); > > Hmm, I don't think it should be the responsibility of this function to > map gdb to remote numbers though. Here I think we should just map > gdb pseudo to gdb raw. Yes I had created that function for arm_ax_pseudo_register_* functions but yes maybe it would be better at a lower level and allow this function to be used by something else. > >> + >> + return double_regnum; >> +} >> + >> +/* Implementation of the ax_pseudo_register_collect gdbarch function. */ >> + >> +static int >> +arm_ax_pseudo_register_collect (struct gdbarch *gdbarch, >> + struct agent_expr *ax, int reg) >> +{ >> + int rawnum = arm_pseudo_register_to_register (gdbarch, reg); >> + >> + /* Error. */ >> + if (rawnum < 0) >> + return 1; >> + >> + ax_reg_mask (ax, rawnum); > > Hmm, seems to me that gdb raw -> target raw mapping should be > either here, or perhaps even in ax_reg / ax_reg_mask? > Yes now that you mention it it would make sense in ax_reg/reg_mask. > Consider the case of an expression requiring the collection of > a _raw_ register, thus not even reaching here. Looking at > ax-gdb.c/ax-general.c I don't see where is anything mapping gdb raw numbers > to remote/tdesc numbers? So how does _that_ work? Are the register masks that gdb > is computing actually wrong for the target, and things just happen > to work because gdbserver ignores them and always collects all registers? > I would assume so indeed! I'll make this a small series send another patch to apply prior to this one with the change to ax_reg, ax_reg_mask. Thanks, Antoine